CS-261 Failed to accept policy changes during approval#2604
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
chasprowebdev
changed the title
Contributor
|
After the policy is submitted for approval, sometimes pendingVersionId is cleared for any reason. |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
claudfuen
pushed a commit
that referenced
this pull request
Apr 20, 2026
# [3.25.0](v3.24.0...v3.25.0) (2026-04-20) ### Bug Fixes * **app:** hide policy alerts if pending version is cleared ([#2604](#2604)) ([a7389a1](a7389a1)) * **controls:** dedupe policyIds/taskIds before validating length ([5de8a67](5de8a67)) * **controls:** scope FK inputs to caller org in create() ([2b8991f](2b8991f)) * **framework-editor:** stop auto-linking all framework requirements on control create ([#2605](#2605)) ([3f681e5](3f681e5)) * **frameworks:** address PR review feedback ([e3b58bc](e3b58bc)) * **frameworks:** address review feedback — tenant-FK hardening + custom-framework parity ([d296e2a](d296e2a)) * **frameworks:** dedupe linked requirements and scope lookups by org ([c39a7c5](c39a7c5)) * **frameworks:** remove debug log and return DB-reported link counts ([409be26](409be26)) * **onboarding:** set default value for organizationId in updatePolicy schema ([c3a50db](c3a50db)) ### Features * **controls:** add endpoints to link policies, tasks, and requirements to controls ([0380ff7](0380ff7)) * **frameworks:** add custom framework and requirement management endpoints ([a81af3e](a81af3e))
Contributor
|
🎉 This PR is included in version 3.25.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated pull request to merge chas/accept-policy-changes into dev.
It was created by the [Auto Pull Request] action.
Summary by cubic
Addresses CS-261 by preventing false “pending approval” states. Alerts and publish actions are now gated by a real pending version, so publishing is allowed once the pending version is cleared.
isPendingApprovalandpolicy.pendingVersionIdare both true.pendingVersionIdis cleared.Written for commit 1d315ab. Summary will update on new commits.