feat(ecmascript): Builtin class constructors and field initializers #426
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this silly lump of code, Nova now supports field initializers with default constructors.
Field initializers with derived class ECMAScript constructors do not yet work because the initializers are incorrectly run at the very beginning of the ECMAScript constructor instead of as the last step of the
super()call. Fixing this wouldn't be too big of a deal but the simple fix won't fix cases like:Instead of logging
100and then0, this would instead log100twice because the field initializer code would incorrectly use thecounterparameter. It seems likely that I will need to add proper ECMAScriptConstructorFunction variants after all. Luckily now the variants are at least a little less painful to add.