feat: WeakMap, WeakSet, WeakRef behind the weak-refs feature
#442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
aapoalas
reviewed
Oct 13, 2024
Member
aapoalas
left a comment
aapoalas
left a comment
There was a problem hiding this comment.
suggestion:: How about combining WeakMap, WeakSet, WeakRef, and FinalizationRegistry under a combined "weak-refs" feature? Disabling that feature would mean that the engine does not have any ephemerons and thus garbage collection can be done with a very simple algorithm (the one we use right now; I haven't actually implemented ephemeron collection yet).
Member
Author
|
sounds good! |
load1n9
changed the title
weak-refs feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.