feat(ecmascript): Implement dataview get and set methods
#455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aapoalas
requested changes
Nov 4, 2024
Member
aapoalas
left a comment
aapoalas
left a comment
There was a problem hiding this comment.
Had a few minor issues and some suggestions, but in general looks pretty damn good to me! Good job and thank you <3
nova_vm/src/ecmascript/builtins/array_buffer/abstract_operations.rs
Outdated
Show resolved
Hide resolved
nova_vm/src/ecmascript/builtins/structured_data/data_view_objects/data_view_prototype.rs
Outdated
Show resolved
Hide resolved
aapoalas
previously approved these changes
Nov 8, 2024
Member
aapoalas
left a comment
aapoalas
left a comment
There was a problem hiding this comment.
Looks good to me, though I had a suggestion through which we can still avoid passing GC into the set_view_value method.
nova_vm/src/ecmascript/builtins/structured_data/data_view_objects/data_view_prototype.rs
Show resolved
Hide resolved
Member
Author
|
@aapoalas Ready to merge when you are :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented the
get*andset*methods but it may still not be entirely correct due to theget_offset_by_byteandset_offset_by_bytemethods I added toDataBlock. I also added a few methods to theViewablewhich I am somewhat unsure about if it's the correct approach.Closes #152