Skip to content

chore: remove old todos related to wt8::CodePoint #875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 14, 2025
Merged

chore: remove old todos related to wt8::CodePoint #875

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
34b6618
chore(small_string): Remove old todo
GeoffreyParrier Oct 14, 2025
9418fdf
chore: remove old todo
GeoffreyParrier Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion nova_vm/src/ecmascript/types/language/string/data.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,6 @@ impl StringHeapData {
}
}

// TODO: This should return a wtf8::CodePoint.
pub fn char_code_at(&self, idx: usize) -> CodePoint {
let (utf8_idx, take_latter_half): (usize, bool) = if idx != 0 {
match self.index_mapping() {
Expand Down
1 change: 0 additions & 1 deletion small_string/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,6 @@ impl SmallString {
unreachable!("Could not find code point index");
}

// TODO: This should return a wtf8::CodePoint.
pub fn char_code_at(&self, idx: usize) -> CodePoint {
if self.is_ascii() {
// SAFETY: ASCII is valid UTF-8.
Expand Down
Loading