Skip to content

Commit 848ce1d

Browse files
committed
fix(engine): declare builtin.ts as side-effectful to prevent tree-shaking
sideEffects:false told bundlers the import './charts/builtin' side-effect in compile.ts was safe to drop. Vite would strip it when resolving the engine via source alias, leaving the renderer registry empty. All chart types returned empty marks with no error. Declare builtin.ts (and dist/index.js) as side-effectful so bundlers keep the registration import.
1 parent b5d4020 commit 848ce1d

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

packages/engine/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
"dist",
3131
"src"
3232
],
33-
"sideEffects": false,
33+
"sideEffects": ["./src/charts/builtin.ts", "./dist/index.js"],
3434
"keywords": [
3535
"chart",
3636
"visualization",

0 commit comments

Comments
 (0)