feature(datasources): support for accessing sqlalchemy provided data engines with a sing SQLDataSource and DatabaseReader #189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
vegito22
approved these changes
Mar 16, 2024
vignesh-makerdojo
pushed a commit
that referenced
this pull request
Mar 16, 2024
…engines with a sing SQLDataSource and DatabaseReader (#189)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal:
This pull request aims to investigate the feasibility of integrating a unified connector capable of accommodating multiple database engines through SQLAlchemy, thereby enhancing the flexibility and versatility of our system.
Changes:
Implemented a consolidated connector capable of seamlessly supporting various database engines utilizing SQLAlchemy. This consolidation streamlines the codebase and facilitates more manageable maintenance and future enhancements.
Testing:
Reviewers:
@ajhai and @vegito22