Skip to content

Conversation

@tschm
Copy link
Owner

@tschm tschm commented Nov 14, 2025

No description provided.

@coderabbitai
Copy link

coderabbitai bot commented Nov 14, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

ms32035 and others added 6 commits November 14, 2025 09:44
This PR enables support for plotly 6.
Here we test all notebooks (e.g. we run them from top to bottom) with
nbmake. nbmake is a package produced by our friend Alex Remedios, see
https://github.com/treebeardtech/nbmake. Please note that we had to
update the notebooks following a change in yfinance. We have replaced
"Adj Close" with "Close".
* moves linting to `ruff`
* adds `editorconfig`
* makes tests dependent on passing linting

Also fixes linting in some files (but not all).
merges all PR CI jobs into one workflow, which allows gating and
conditionals.

Also makes all workflows conditional on basic code quality checks to
avoid unnecessary runs.
…#662)

* adds a CI job, `pytest-nosoftdeps`, to test the package without soft
dependencies.
* isolates soft dependency `matplotlib` in tests and the plotting module
* isolates the `ecos` dependency almost entirely. There is one default
that remains, which is deprecated and scheduled for removal in 1.7.0.
* adds `scikit-base` soft dependency (without further dependencies) to
manage soft dependencies

This is also useful to check whether soft dependencies are properly
isolated.
restores the `requirements.txt` for downwards compatibility
@tschm tschm changed the base branch from src to main November 15, 2025 07:28
@tschm tschm merged commit 335c809 into tschm:main Nov 15, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants