feat(probes): Add name property to schematic and simulation voltage probes #353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seveibar
approved these changes
Nov 17, 2025
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Comment on lines
+48
to
+60
| test("simulation_voltage_probe parses with name", () => { | ||
| const input: SimulationVoltageProbeInput = { | ||
| type: "simulation_voltage_probe", | ||
| source_net_id: "net1", | ||
| name: "My Probe", | ||
| } | ||
|
|
||
| const result = simulation_voltage_probe.parse(input) | ||
| const probe = result as SimulationVoltageProbe | ||
|
|
||
| expect(probe.source_net_id).toBe("net1") | ||
| expect(probe.name).toBe("My Probe") | ||
| }) |
Contributor
There was a problem hiding this comment.
This test file violates the rule that a *.test.ts file may have AT MOST one test(...) function. The file now contains 2 test functions after adding the new test on line 48. The file should be split into multiple numbered files, such as simulation_voltage_probe1.test.ts and simulation_voltage_probe2.test.ts, with each file containing only one test function.
Spotted by Graphite Agent (based on custom rule: Custom rule)
Is this helpful? React 👍 or 👎 to let us know.
Contributor
|
Thank you for your contribution! 🎉 PR Rating: ⭐⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the optional name property to both schematic_voltage_probe and simulation_voltage_probe.
Previously, this property was missing, making it difficult to distinguish between multiple probes.
The name property has been added to the respective Zod schemas and TypeScript interfaces. Tests have also been
updated to ensure the name property is correctly parsed and accessible.