Setup Publishing and building with tsup #5
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@seveibar you might need to allow running github workflows on PRs for this repo too |
seveibar
requested changes
Dec 15, 2024
Contributor
seveibar
left a comment
seveibar
left a comment
There was a problem hiding this comment.
- tscircuit-plop shouldn't be added as a dependency
- shouldn't change the
createServer.tsfile - didn't add the
binfield to package.json to make this executable as a cli
Contributor
|
superceded by #6 /tip $5 |
|
🎉🎈 @Anshgrover23 has been awarded $5! 🎈🎊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2
/claim #2