Fix the autolayout for the pinHeader component having no explicit facingDirection #1565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
seveibar
reviewed
Oct 23, 2025
| ...props, | ||
| facingDirection: props.facingDirection ?? "right", | ||
| } | ||
| super(propsWithDefaults) |
There was a problem hiding this comment.
don't modify props (props are immutable)
Instead, create a function called _getFacingDirection() and force anything using facing direction to use that. This allows much cleaner overrides and preserves the user's definitions (which makes errors and lots of other stuff more clear)
seveibar
reviewed
Oct 23, 2025
| import type { BaseSymbolName } from "lib/utils/constants" | ||
|
|
||
| export class PinHeader extends NormalComponent<typeof pinHeaderProps> { | ||
| _getFacingDirection(): "left" | "right" | "up" | "down" { |
There was a problem hiding this comment.
sorry
Suggested change
| _getFacingDirection(): "left" | "right" | "up" | "down" { | |
| _getSchFacingDirection(): "left" | "right" | "up" | "down" { |
seveibar
reviewed
Oct 23, 2025
| // Check for components with _getFacingDirection method (e.g., PinHeader with defaults) | ||
| if ( | ||
| (component as PinHeader)._getFacingDirection && | ||
| typeof (component as PinHeader)._getFacingDirection === "function" |
There was a problem hiding this comment.
if ((component as PinHeader)?._getFacingDirection()) {There was a problem hiding this comment.
or even better
if (component._getSchFacingDirection()) {then define in the PrimitiveComponent _getFacingSchFacingDirection() { return null }
seveibar
reviewed
Oct 23, 2025
imrishabh18
force-pushed
the
default-pinheader-facingDirection
branch
from
b73ea54 to
daa1717
Compare
imrishabh18
changed the title
seveibar
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
After