Fix schpinspacing width

lib/components/base-components/NormalComponent/NormalComponent.ts

@@ -1233,6 +1233,26 @@ export class NormalComponent<
     )
   }
 
+  /**
+   * Extract pin labels from ports using existing Port logic
+   */
+  _getPinLabelsFromPorts(): Record<string, string> {
+    const ports = this.selectAll("port") as Port[]
+    const pinLabels: Record<string, string> = {}
+
+    for (const port of ports) {
+      const pinNumber = port.props.pinNumber
+      if (pinNumber !== undefined) {
+        const bestLabel = port._getBestDisplayPinLabel()
+        if (bestLabel) {
+          pinLabels[`pin${pinNumber}`] = bestLabel
+        }
+      }
+    }
+
+    return pinLabels
+  }
+
   _getSchematicBoxDimensions(): SchematicBoxDimensions | null {
     // Only valid if we don't have a schematic symbol
     if (this.getSchematicSymbol()) return null
@@ -1244,19 +1264,26 @@ export class NormalComponent<
 
     const pinSpacing = props.schPinSpacing ?? 0.2
 
+    const pinLabelsFromPorts = this._getPinLabelsFromPorts()
+    // Merge with props.pinLabels for label-to-pin-number mapping
+    const allPinLabels = {
+      ...pinLabelsFromPorts,
+      ...props.pinLabels,
+    }
+
     const dimensions = getAllDimensionsForSchematicBox({
       schWidth: props.schWidth,
       schHeight: props.schHeight,
       schPinSpacing: pinSpacing,
       numericSchPinStyle: getNumericSchPinStyle(
         props.schPinStyle,
-        props.pinLabels,
+        allPinLabels,
       ),
 
       pinCount,
 
       schPortArrangement: this._getSchematicPortArrangement()!,
-      pinLabels: props.pinLabels,
+      pinLabels: allPinLabels,
     })
 
     return dimensions

lib/components/primitive-components/Port/Port.ts

@@ -468,6 +468,38 @@ export class Port extends PrimitiveComponent<typeof portProps> {
     this.pcb_port_id = pcb_port.pcb_port_id
   }
 
+  /**
+   * Get the best display label for this port based on port_hints
+   * Filters out generic patterns and applies showPinAliases logic
+   */
+  _getBestDisplayPinLabel(): string | undefined {
+    const { db } = this.root!
+    const sourcePort = db.source_port.get(this.source_port_id!)
+
+    // Filter out generic patterns like "pin1", "1", etc.
+    const labelHints: string[] = []
+    for (const portHint of sourcePort?.port_hints ?? []) {
+      if (portHint.match(/^(pin)?\d+$/)) continue
+      if (
+        portHint.match(/^(left|right)/) &&
+        !sourcePort?.name.match(/^(left|right)/)
+      )
+        continue
+      labelHints.push(portHint)
+    }
+
+    const parentNormalComponent = this.getParentNormalComponent()
+    const showPinAliases = parentNormalComponent?.props?.showPinAliases
+
+    if (showPinAliases && labelHints.length > 0) {
+      return labelHints.join("/")
+    } else if (labelHints.length > 0) {
+      return labelHints[0]
+    }
+
+    return undefined
+  }
+
   doInitialSchematicPortRender(): void {
     const { db } = this.root!
     const { _parsedProps: props } = this
@@ -514,28 +546,8 @@ export class Port extends PrimitiveComponent<typeof portProps> {
       }[localPortInfo.side] as "up" | "down" | "left" | "right"
     }
 
-    const sourcePort = db.source_port.get(this.source_port_id!)
-
-    const labelHints: string[] = []
-    for (const portHint of sourcePort?.port_hints ?? []) {
-      if (portHint.match(/^(pin)?\d+$/)) continue
-      if (
-        portHint.match(/^(left|right)/) &&
-        !sourcePort?.name.match(/^(left|right)/)
-      )
-        continue
-      labelHints.push(portHint)
-    }
-
-    let bestDisplayPinLabel: string | undefined = undefined
+    const bestDisplayPinLabel = this._getBestDisplayPinLabel()
     const parentNormalComponent = this.getParentNormalComponent()
-    const showPinAliases = parentNormalComponent?.props?.showPinAliases
-    if (showPinAliases && labelHints.length > 0) {
-      bestDisplayPinLabel = labelHints.join("/")
-    } else if (labelHints.length > 0) {
-      // show the first label hint
-      bestDisplayPinLabel = labelHints[0]
-    }
 
     const schematicPortInsertProps: Omit<SchematicPort, "schematic_port_id"> = {
       type: "schematic_port",

lib/utils/schematic/getAllDimensionsForSchematicBox.ts

@@ -1,6 +1,8 @@
 import { getSizeOfSidesFromPortArrangement } from "./getSizeOfSidesFromPortArrangement"
 import { parsePinNumberFromLabelsOrThrow } from "./parsePinNumberFromLabelsOrThrow"
 
+const DEFAULT_SCHEMATIC_BOX_PADDING_MM = 0.4
+
 export type VerticalPortSideConfiguration = {
   direction?: "top-to-bottom" | "bottom-to-top"
   pins: number[]
@@ -344,13 +346,31 @@ export const getAllDimensionsForSchematicBox = (
   }
 
   // Use lengths to determine schWidth and schHeight
-  let schWidth = params.schWidth
-  if (schWidth === undefined) {
-    schWidth = Math.max(
-      sideLengths.top + params.schPinSpacing * 2,
-      sideLengths.bottom + params.schPinSpacing * 2,
+  let resolvedSchWidth = params.schWidth
+  if (resolvedSchWidth === undefined) {
+    resolvedSchWidth = Math.max(
+      sideLengths.top + DEFAULT_SCHEMATIC_BOX_PADDING_MM,
+      sideLengths.bottom + DEFAULT_SCHEMATIC_BOX_PADDING_MM,
     )
 
+    // Check if there are actual pin labels on left/right sides
+    if (params.pinLabels) {
+      const leftRightPins = orderedTruePorts.filter(
+        (p) => p.side === "left" || p.side === "right",
+      )
+      const hasLeftRightLabels = leftRightPins.some(
+        (p) =>
+          params.pinLabels?.[`pin${p.pinNumber}`] ||
+          params.pinLabels?.[p.pinNumber],
+      )
+
+      if (hasLeftRightLabels) {
+        // Apply minimum width when there are left/right pins with labels
+        const MIN_WIDTH_FOR_SIDE_PINS = 0.5
+        resolvedSchWidth = Math.max(resolvedSchWidth, MIN_WIDTH_FOR_SIDE_PINS)
+      }
+    }
+
     const labelWidth = params.pinLabels
       ? Math.max(
           ...Object.values(params.pinLabels).map(
@@ -361,21 +381,21 @@ export const getAllDimensionsForSchematicBox = (
 
     // When label is present, only then add some padding to the width
     const LABEL_PADDING = labelWidth > 0 ? 1.1 : 0
-    schWidth = Math.max(schWidth, labelWidth + LABEL_PADDING)
+    resolvedSchWidth = Math.max(resolvedSchWidth, labelWidth + LABEL_PADDING)
   }
 
   let schHeight = params.schHeight
   if (!schHeight) {
     schHeight = Math.max(
-      sideLengths.left + params.schPinSpacing * 2,
-      sideLengths.right + params.schPinSpacing * 2,
+      sideLengths.left + DEFAULT_SCHEMATIC_BOX_PADDING_MM,
+      sideLengths.right + DEFAULT_SCHEMATIC_BOX_PADDING_MM,
     )
   }
 
   const trueEdgePositions = {
     // Top left corner
     left: {
-      x: -schWidth / 2 - portDistanceFromEdge,
+      x: -resolvedSchWidth / 2 - portDistanceFromEdge,
       y: sideLengths.left / 2,
     },
     // bottom left corner
@@ -385,7 +405,7 @@ export const getAllDimensionsForSchematicBox = (
     },
     // bottom right corner
     right: {
-      x: schWidth / 2 + portDistanceFromEdge,
+      x: resolvedSchWidth / 2 + portDistanceFromEdge,
       y: -sideLengths.right / 2,
     },
     // top right corner
@@ -426,12 +446,12 @@ export const getAllDimensionsForSchematicBox = (
       return port
     },
     getSize(): { width: number; height: number } {
-      return { width: schWidth, height: schHeight }
+      return { width: resolvedSchWidth, height: schHeight }
     },
     getSizeIncludingPins(): { width: number; height: number } {
       return {
         width:
-          schWidth +
+          resolvedSchWidth +
           (sidePinCounts.leftSize || sidePinCounts.rightSize ? 0.4 : 0),
         height:
           schHeight +