Skip to content

Conversation

@rushabhcodes
Copy link
Contributor

This pull request refactors the way VoltageSource component props are imported and used, aligning them with the shared props package and removing local duplication. The main goal is to ensure consistency and maintainability by relying on the centralized @tscircuit/props definitions.

Props refactoring and unification:

  • Replaced local definitions of VoltageSourceProps and voltageSourceProps in VoltageSource.ts with imports from @tscircuit/props, removing redundant code and ensuring consistency across the codebase.
  • Updated the TscircuitElements interface in intrinsic-jsx.ts to use Props.VoltageSourceProps instead of the locally defined VoltageSourceProps, further unifying prop types. [1] [2]

@vercel
Copy link

vercel bot commented Nov 24, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
tscircuit-core-benchmarks Ready Ready Preview Comment Nov 24, 2025 5:29pm

@MustafaMulla29 MustafaMulla29 merged commit ae08d79 into tscircuit:main Nov 25, 2025
12 checks passed
@rushabhcodes rushabhcodes deleted the use-voltage-source-prop branch November 25, 2025 18:06
@tscircuitbot
Copy link
Contributor


Thank you for your contribution! 🎉

PR Rating: ⭐⭐⭐
Impact: Major

Track your contributions and see the leaderboard at: tscircuit Contribution Tracker


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants