Skip to content

Conversation

@Ayushjhawar8
Copy link
Contributor

Before:
image

After:
image

@vercel
Copy link

vercel bot commented Nov 15, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
docs Ready Ready Preview Comment Nov 15, 2025 3:54pm

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

const threeDUrl = useMemo(() => {
if (browser3dView && typeof fsMapOrCode === "string") {
return createPngUrl(fsMapOrCode, "3d")
}

P1 Badge Pass background_color through browser 3D preview path

The new background_color parameter is appended in the fs-map and manual code paths, but the branch that runs when browser3dView is true still returns createPngUrl(fsMapOrCode, "3d") without adding the same parameter. When the preview uses this shortcut, the generated URL will continue to omit background_color and the infinite grid remains, so the bug the commit intends to fix still reproduces. Forward the color option to createPngUrl or append it to the returned URL to make the behaviour consistent across all branches.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Ayushjhawar8 Ayushjhawar8 merged commit a10a516 into tscircuit:main Nov 15, 2025
5 checks passed
@Ayushjhawar8 Ayushjhawar8 deleted the fixInfinite branch November 15, 2025 16:45
@tscircuitbot
Copy link


Thank you for your contribution! 🎉

PR Rating: ⭐⭐
Impact: Minor

Track your contributions and see the leaderboard at: tscircuit Contribution Tracker


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants