Add support for imports that use tsconfig.json baseUrl #1292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@seveibar Please review |
seveibar
reviewed
Oct 16, 2025
Co-authored-by: Severin Ibarluzea <seve700@gmail.com>
|
@seveibar I have resolved comments |
seveibar
requested changes
Oct 16, 2025
seveibar
reviewed
Oct 16, 2025
|
|
||
| if (!unknownFilePath.startsWith("./") && !unknownFilePath.startsWith("../")) { | ||
| const viaTsconfig = resolveWithTsconfigPaths({ | ||
| const resolvedPathFromPaths = resolveWithTsconfigPaths({ |
There was a problem hiding this comment.
Suggested change
| const resolvedPathFromPaths = resolveWithTsconfigPaths({ | |
| const resolvedPathFromTsconfigPaths = resolveWithTsconfigPaths({ |
seveibar
approved these changes
Oct 16, 2025
|
@seveibar Thanks for merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/claim #1282
/closes #1282
Fixes issue #1282 by making sure don't need to specify "paths" in tsconfig in order to import files from the root directory
Created 3 test cases to verify it works
TEST LOGS:
USER@DESKTOP-1PHUG1C MINGW64 ~/3D Objects/eval (fix-1282)
$ bun test tests/features/tsconfig-paths-resolution.test.tsx
bun test v1.2.23 (cf136713)
tests\features\tsconfig-paths-resolution.test.tsx:
✓ resolves imports using tsconfig paths aliases [1391.00ms]
✓ throws error when tsconfig path alias cannot be resolved (instead of trying jsdelivr)
✓ resolves imports using tsconfig baseUrl [609.00ms]
3 pass
0 fail
5 expect() calls
Ran 3 tests across 1 file. [3.97s]