Ignore type-only imports when resolving dependencies #1359
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| while ((match = importRegex.exec(code)) !== null) { | ||
| const fullMatch = match[0] | ||
| if (/^\s*import\s+type\b/.test(fullMatch)) { | ||
| continue | ||
| } | ||
| imports.push(match[1]) |
There was a problem hiding this comment.
The new filter only skips statements that literally start with import type, but TypeScript also allows pure type imports in the form import { type Foo } from "./foo". For those statements the regex still pushes the module name because the line begins with import {, so type-only dependencies remain in the returned list and continue to trigger circular-detection logic despite having no runtime dependency. Consider detecting inline type specifiers (when the statement contains only type bindings) before pushing the import name.
Useful? React with 👍 / 👎.
1 participant
Summary
import typestatements when collecting dependency namesTesting
https://chatgpt.com/codex/tasks/task_b_68f7fa6cb194832e94af7cc15f816ee3