persist onboarding tips visibility#43
Merged
seveibar merged 3 commits intotscircuit:mainfrom Oct 10, 2024
Merged
Conversation
|
@mrudulpatil18 is attempting to deploy a commit to the tscircuit Team on Vercel. A member of the Team first needs to authorize it. |
seveibar
reviewed
Oct 8, 2024
|
|
||
| export const LandingHero = () => { | ||
| const [visible, setVisible] = useState(true) | ||
| const { should_onboarding_tips_be_closed, setOnboardingTipsClosed } = useGlobalStore() |
Contributor
There was a problem hiding this comment.
use a selector with the global store- it will cause less react-rerenders (important react optimization)
seveibar
requested changes
Oct 8, 2024
Contributor
seveibar
left a comment
seveibar
left a comment
There was a problem hiding this comment.
very close! minor change
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
|
format failure, biome vscode extension w/ format on save or run |
Contributor
Author
fixed |
seveibar
approved these changes
Oct 10, 2024
This was referenced Jan 24, 2025
This was referenced Feb 8, 2025
This was referenced Mar 2, 2025
This was referenced Mar 25, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #38
should_onboarding_tips_be_closed&setOnboardingTipsClosedto global storeLandingHeroto use global store for onboarding tips visibility