Add examples and hide unhide feature #2
Conversation
- Always show 3D visualization by default - Remove Hide 3D/Show 3D toggle button - Remove Rebuild 3D button - Remove Root and Output checkboxes (always enabled) - Remove Dataset Information and Usage Instructions sections - Keep Obstacles toggle and advanced controls (opacity, wireframe, etc.) - Clean up component props and state management
Adds a toggle for orthographic camera view in the CapacityNode3dDebugger component. - Introduces an 'isOrthographic' state and a corresponding checkbox. - Modifies ThreeBoardView to dynamically switch between PerspectiveCamera and OrthographicCamera. - Adjusts camera positioning and resize handling for the orthographic view, providing a top-down initial perspective.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
IMPLEMENTATION_SUMMARY.md
Outdated
| @@ -0,0 +1,126 @@ | |||
| # CapacityNode3dDebugger Implementation Summary | |||
| @@ -0,0 +1,951 @@ | |||
| import { | |||
There was a problem hiding this comment.
this is ok for now but this file needs to be broken up (next PR, i would definitely use Repomix + ChatGPT Pro to do the breakup because agents tend to do refactors very poorly, after Pro gives you instructions, just copy and paste those instructions to a coding agent like claude)
bun.lock
Outdated
| @@ -0,0 +1,583 @@ | |||
| { | |||
There was a problem hiding this comment.
this shouldn't be commited
seveibar
left a comment
seveibar
left a comment
There was a problem hiding this comment.
make sure to read over your PRs
|
the format check might be failing because it requires the following in the package.json scripts: |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
lib/CapacityNode3dDebugger.tsx
Outdated
| return m | ||
| }, [layerNames]) | ||
|
|
||
| const layerCount = layerNames.length || srj?.layerCount || 1 |
There was a problem hiding this comment.
layerCount is computed as layerNames.length || srj?.layerCount || 1, so as soon as there is at least one node, any SRJ-specified layer count is ignored. If the SRJ describes more layers than are present in the node layer names (e.g., nodes labeled only “top” with srj.layerCount of 4 or obstacles with zLayers > 0), layerCount collapses to 1, causing obstacles on higher layers to be skipped by the z >= layerCount check and the root box/camera fit to use the wrong stack height. Prefer using the SRJ layerCount (or the max of both) so multi-layer boards render correctly.
Useful? React with 👍 / 👎.
0hmX
force-pushed
the
intital-example
branch
from
b182cde to
6a99d4b
Compare
|
Thank you for your contribution! 🎉 PR Rating: ⭐⭐⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
a.mp4
vercel preview
https://trace-capacity-visualizer-afcc3ah0w-tscircuit.vercel.app/