Fix posix build #73
Merged
Fix posix build #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 29, 2025 03:13
1.Disabled AMX (Advanced Matrix Extensions): -mno-amx-tile -mno-amx-int8 -mno-amx-bf16 → Don't use AMX instructions -mno-avx512bf16 → Don't use AVX512-BF16 instructions -mno-avxvnni → Don't use AVX-VNNI instructions 2. CMake Flags (-DGGML_AMX_TILE=OFF -DGGML_AMX_INT8=OFF -DGGML_AMX_BF16=OFF -DGGML_AVX512_BF16=OFF -DGGML_AVX_VNNI=OFF). Control CMake's build configuration and do two things: -Prevent explicit compiler flags -Prevent preprocessor defines which enables AMX-specific code paths in the source code Signed-off-by: Dinesh Reddy <dreddy@ws02.tsavoritesi.net>
…e. Second call to print profiling results (in tsi_cleanup()) has been commented out. Signed-off-by: Dinesh Reddy <dreddy@ws02.tsavoritesi.net>
dineshReddy6381
requested review from
Nithyanand-G,
akapoor3518,
atrivedi-tsavoritesi,
dmpatra,
gkethamallax,
mikeuhler and
mmankal
as code owners
akapoor3518
approved these changes
Oct 30, 2025
| if [ "$(echo "$1" | tr '[:upper:]' '[:lower:]')" = "release" ]; | ||
| then | ||
| cmake -B build-posix -DGGML_TSAVORITE=ON -DGGML_TSAVORITE_TARGET=posix -DCMAKE_C_FLAGS="-DGGML_PERF_RELEASE -DGGML_TARGET_POSIX -DGGML_TSAVORITE" -DCMAKE_CXX_FLAGS="-DGGML_PERF_RELEASE -DGGML_TARGET_POSIX -DGGML_TSAVORITE" | ||
| cmake -B build-posix -DGGML_TSAVORITE=ON -DGGML_TSAVORITE_TARGET=posix -DGGML_NATIVE=ON -DGGML_AMX_TILE=OFF -DGGML_AMX_INT8=OFF -DGGML_AMX_BF16=OFF -DGGML_AVX512_BF16=OFF -DGGML_AVX_VNNI=OFF -DCMAKE_C_FLAGS="-DGGML_PERF_RELEASE -DGGML_TARGET_POSIX -DGGML_TSAVORITE -mno-amx-tile -mno-amx-int8 -mno-amx-bf16 -mno-avx512bf16 -mno-avxvnni" -DCMAKE_CXX_FLAGS="-DGGML_PERF_RELEASE -DGGML_TARGET_POSIX -DGGML_TSAVORITE -mno-amx-tile -mno-amx-int8 -mno-amx-bf16 -mno-avx512bf16 -mno-avxvnni" |
There was a problem hiding this comment.
Did we make any change for FPGA also?
Author
There was a problem hiding this comment.
Yes, I have tested on both fpga & posix
atrivedi-tsavoritesi
approved these changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested for release, debug & normal build. Tested all models on posix & llama on fpga.
ggml_log.txt