-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to tskit C API 1.0.0 #2061
Conversation
It's not obvious that removing the submodule is better here - won't we have to manually vendor in tskit every time we update then? |
Yes, but we had to update the submodule anyway - I know which one gives me less hassle! Your call! |
Hmm the LWT is the fly in the vendoring ointment. Probably easiest to keep the submodule. |
27e10ad
to
2e98e36
Compare
I'm sure I went round this one a few times relatively recently and decided the submodule was the lesser of n evils |
This cannot proceed until the next tskit python release as the LWT tests fail when used against tskit 0.4.1. |
This should be good to pick up now @benjeffery? |
Codecov Report
@@ Coverage Diff @@
## main #2061 +/- ##
=======================================
Coverage 91.35% 91.35%
=======================================
Files 20 20
Lines 10893 10893
Branches 2273 2273
=======================================
Hits 9951 9951
Misses 515 515
Partials 427 427
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Looks ready to go now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Fixes #2060
Took the liberty of removing the git submodule in the process.