Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add XTable.drop_metadata #2944

Closed
jeromekelleher opened this issue May 3, 2024 · 1 comment · Fixed by #2945
Closed

Add XTable.drop_metadata #2944

jeromekelleher opened this issue May 3, 2024 · 1 comment · Fixed by #2945
Milestone

Comments

@jeromekelleher
Copy link
Member

It's useful to drop metadata on tables. The only question really is how to deal with schemas, how about:

def drop_metadata(self, keep_schema=False):
     """
     Drops all metadata in this table. By default, the schema is also cleared, except if ``keep_schema`` is True.
     """
@jeromekelleher jeromekelleher added this to the Python 0.5.7 milestone May 3, 2024
jeromekelleher added a commit to jeromekelleher/tskit that referenced this issue May 3, 2024
@benjeffery
Copy link
Member

Makes sense to me - more likely to be issues of confusion if the default is to keep the schema.

jeromekelleher added a commit to jeromekelleher/tskit that referenced this issue May 3, 2024
jeromekelleher added a commit to jeromekelleher/tskit that referenced this issue May 3, 2024
@mergify mergify bot closed this as completed in #2945 May 7, 2024
mergify bot pushed a commit that referenced this issue May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants