fix(lexicons): support tid and record-key format in object property
#70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tsky canceled.
|
Contributor
Coverage Report for ./packages/client/
File CoverageNo changed files found. |
shuuji3
force-pushed
the
shuuji3/fix/lexicons
branch
from
ef3e26f to
adf4359
Compare
shuuji3
changed the title
tid and record-key format in object property
anbraten
approved these changes
Feb 23, 2025
Collaborator
Author
|
Let's merge this to stop CI error. At least, I couldn't find rules that prohibit using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #67
This seems to be working but I only checked related codes in type generate script. There might be something I missed.
related upstream change: bluesky-social/atproto#2378