Conversation
3815e39 to
2139fa8
Compare
2139fa8 to
8c767a8
Compare
danieleformichelli
approved these changes
Dec 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

TL;DR
Added stream piping functionality and completion handling to
AsyncThrowingStreamWhat changed?
pipedStream()method to pipe standard output and error through the process' standard output and errorawaitCompletion()method to wait for stream completionHow to test?
pipedStream()to verify output is correctly piped:Why make this change?
To provide better control over command output handling by allowing direct piping to standard streams and providing a way to wait for stream completion without needing to manually consume the stream.