fix: lookupExecutable race condition#87
Merged
AndrewBarba merged 5 commits intotuist:mainfrom Aug 15, 2024
Merged
Conversation
pepicrft
reviewed
Aug 15, 2024
pepicrft
reviewed
Aug 15, 2024
|
|
||
| #if os(Windows) | ||
| command = "where" | ||
| command = "C:\\Windows\\System32\\where.exe" |
pepicrft
reviewed
Aug 15, 2024
Comment on lines
+263
to
+264
| process.environment = ProcessInfo.processInfo.environment | ||
| process.currentDirectoryURL = URL(fileURLWithPath: FileManager.default.currentDirectoryPath) |
Contributor
There was a problem hiding this comment.
I wrongly assumed those values would be inherited 😅. Good catch @AndrewBarba
pepicrft
approved these changes
Aug 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was seeing inconsistent behavior in
lookupExectuabledo to a race condition where the data was read before waiting for the task to finish.This PR fixes the race condition by ensuring we wait for process exit before attempting to read data from the pipe
I also changed the signature of
lookupExecutableto either return a URL or throw. I removed the possible nil which would simply surface as a thrown error later on anyway