BL-1633: Add dag to move boundwith files. #701
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also refactors determine_most_recent_date helper method to work with boundwith.
dkinzer
force-pushed
the
BL-1633-add-a-move-bw-files-to-s-3-dag
branch
from
0607481 to
2d5bae2
Compare
sensei100
changed the title
sensei100
reviewed
Mar 21, 2022
| } | ||
|
|
||
| DAG = airflow.DAG( | ||
| "catalog_move_alma_sftp_bw_to_s3", |
Contributor
Contributor
There was a problem hiding this comment.
@dkinzer @sensei100 I'm fine with simplifying the names. Alternatively we could do "boundwith_move_alma_sftp_to_s3"? I think having a different prefix helps in distinguishing it more easily from "catalog_move_alma_sftp_to_s3"?
Member
Author
|
@sensei100 there is another subtask to refactor the full reindex to work with new boundwith files in an s3 (https://tulibdev.atlassian.net/browse/BL-1634) |
sensei100
approved these changes
Mar 22, 2022
dkinzer
force-pushed
the
BL-1633-add-a-move-bw-files-to-s-3-dag
branch
from
d33424f to
0d936ea
Compare
Member
Author
|
@ebtoner I updated the name of the dag per your suggestion. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also refactors determine_most_recent_date helper method to work with boundwith.