Skip to content

Bug fix: quotes incorrectly parsed by wrapNumbers resulting in broken json #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 14, 2017
Merged

Bug fix: quotes incorrectly parsed by wrapNumbers resulting in broken json #134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion extension/src/json-viewer/content-extractor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,14 +71,15 @@ function wrapNumbers(text) {
var buffer = "";
var numberBuffer = "";
var isInString = false;
var charIsEscaped = false;
var isInNumber = false;
var previous = "";
var beforePrevious = "";

for (var i = 0, len = text.length; i < len; i++) {
var char = text[i];

if (char == '"' && (previous != '\\' || (previous == '\\' && beforePrevious == '\\'))) {
if (char == '"' && !charIsEscaped) {
isInString = !isInString;
}

Expand All @@ -99,6 +100,9 @@ function wrapNumbers(text) {
numberBuffer = "";
}

// this applies to the _next_ character - the one used in the next iteration
charIsEscaped = (char == '\\') ? !charIsEscaped : false

if (isInNumber) {
numberBuffer += char;

Expand Down
1 change: 1 addition & 0 deletions tests/test.backslash.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{
"triple-backslash": "\\\"99\\\"",
"path": "C:\\foobar\\",
"number": 123,
"foo": "bar"
Expand Down