Skip to content

Added option to show url as anchor tag #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2017
Merged

Added option to show url as anchor tag #173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions extension/pages/options.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,9 @@ <h2>Add-ons</h2>
<li>
<strong>"clickableUrls"</strong> - <span class="hint">Make URLs clickable (boolean). Default true</span>
</li>
<li>
<strong>"wrapLinkWithAnchorTag"</strong> - <span class="hint">Add URLs as anchor tag (boolean). Default false</span>
</li>
<li>
<strong>"openLinksInNewWindow"</strong> - <span class="hint">Open URLs in the same window/tab (boolean). Default true</span>
</li>
Expand Down
12 changes: 12 additions & 0 deletions extension/src/json-viewer/highlighter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,14 @@ Highlighter.prototype = {
elements.forEach(function(node) {
node.classList.add("cm-string-link");
node.setAttribute("data-url", decodedText);
if (self.wrapLinkWithAnchorTag()) {
var linkTag = document.createElement("a");
linkTag.href = decodedText;
linkTag.setAttribute('target', '_blank')
linkTag.innerHTML = decodedText;
node.innerHTML = "";
node.appendChild(linkTag);
}
});
}
});
Expand Down Expand Up @@ -200,6 +208,10 @@ Highlighter.prototype = {
return this.options.addons.clickableUrls;
},

wrapLinkWithAnchorTag: function() {
return this.options.addons.wrapLinkWithAnchorTag;
},

openLinksInNewWindow: function() {
return this.options.addons.openLinksInNewWindow;
},
Expand Down
1 change: 1 addition & 0 deletions extension/src/json-viewer/options/defaults.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ module.exports = {
alwaysRenderAllContent: false,
sortKeys: false,
clickableUrls: true,
wrapLinkWithAnchorTag: false,
openLinksInNewWindow: true,
autoHighlight: true
},
Expand Down