Skip to content

Conversation

@jennyxing
Copy link

#122 changes the default from false to true.

#122 changes the default from false to true.
@tulios
Copy link
Owner

tulios commented Oct 26, 2017

Hi, thanks for the PR. This is just changing the label of showArraySize, to change the default value you have to change this file: https://github.com/tulios/json-viewer/blob/master/extension/src/json-viewer/options/defaults.js#L21

It's not enabled by default because I don't like the looks of it right now (Array[7][), I want to work on the design before it's enabled by default.

@jennyxing
Copy link
Author

jennyxing commented Oct 26, 2017

I currently see the array sizes in the latest release (0.18.0), but in my options page I don't have it explicitly enabled:
image
https://github.com/tulios/json-viewer/pull/122/files#diff-c42228554cb75369d0e2cd9b49487adbR20 changes that line to true. Was it not merged to master?

@tulios
Copy link
Owner

tulios commented Apr 3, 2018

Fixed in #179

@tulios tulios closed this Apr 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants