Skip to content

implement Clone for Arc<Mutex> types #1412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jussisaurio merged 3 commits into from
May 3, 2025
Merged

implement Clone for Arc<Mutex> types #1412

jussisaurio merged 3 commits into from
May 3, 2025

Conversation

@mrchantey
Copy link
Contributor

@mrchantey mrchantey commented Apr 27, 2025

Statement and Rows both have a private Arc, implementing clone avoids users needing to Arc it again.

@mrchantey mrchantey requested a review from penberg as a code owner April 27, 2025 14:25
@mrchantey
Copy link
Contributor Author

mrchantey commented May 1, 2025

Might want it to be a seperate pr but I've also added Row::column_count for a similar api to libsql when getting values out of a row.

@jussisaurio jussisaurio merged commit 5f91d30 into tursodatabase:main May 3, 2025
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PThorpe92 PThorpe92 PThorpe92 approved these changes

@penberg penberg Awaiting requested review from penberg penberg is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mrchantey @PThorpe92 @jussisaurio