Skip to content

Conversation

@m4salah
Copy link
Contributor

@m4salah m4salah commented May 17, 2025

Use SmolStr instead of String CreateVirtualTable struct TODO -> Done

@PThorpe92
Copy link
Collaborator

PThorpe92 commented May 17, 2025

I am not sure we want to be bringing in a dependency here, especially for this one ast node.

(that TODO comment is from a vendored library, was not one of us that wrote it)

@m4salah
Copy link
Contributor Author

m4salah commented May 18, 2025

I am not sure we want to be bringing in a dependency here, especially for this one ast node.

(that TODO comment is from a vendored library, was not one of us that wrote it)

I saw it in the Todo so I did it, nevermind you can close it.

@PThorpe92
Copy link
Collaborator

I am not sure we want to be bringing in a dependency here, especially for this one ast node.
I saw it in the Todo so I did it, nevermind you can close it.
👍

@PThorpe92 PThorpe92 closed this May 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants