Skip to content

fix: Style regression from v0.4.5 #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 18, 2025
Merged

fix: Style regression from v0.4.5 #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions tcp_modbus_aio/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,8 +133,10 @@ def __init__(

def __repr__(self) -> str:
last_ping_msg = (
f"{self._last_ping_latency*1000:.1f}ms ping ({(time.perf_counter() - self._last_ping_timestamp)*1000:03d}ms ago)"
if self._last_ping_latency is not None and self._last_ping_timestamp is not None
f"{self._last_ping_latency*1000:.1f}ms ping "
f"({(time.perf_counter() - self._last_ping_timestamp)*1000:03d}ms ago)"
if self._last_ping_latency is not None
and self._last_ping_timestamp is not None
else "no ping"
)
return (
Expand Down Expand Up @@ -398,7 +400,10 @@ async def is_pingable(self) -> bool:
await self._first_ping_event.wait()

# each failed ping takes 1 second. Tolerate 1 failed ping.
return time.perf_counter() - self._last_ping_timestamp < 2
return (
self._last_ping_timestamp is not None
and time.perf_counter() - self._last_ping_timestamp < 2
)

async def send_modbus_message(
self,
Expand Down