Merged
Conversation
…con button; update docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Buttons no longer have an attribute selector. Instead, we generate a grouped selector based on the variants you choose to include in
$button-variants. This generates the following out of the box:Input-based toggle buttons now put their inputs inside the
<label>, with.btn-checkgoing on the label. This reduces selector complexity—no more sibling selectors, ugh yay—and simplifies markup.Active, checked, and disabled states have been fixed.
There's a new
.btn-styledvariant that replaces our previous global options method for styling buttons with gradients, shadows, etc. Now, for.btn-solid, add.btn-styledand you get beautiful buttons out of the box.New docs including a button playground for seeing how variant, size, and more affects buttons.
New
.btn-icon.Button sizes are now a Sass map—scales better for adding/removing. Now includes an
xsbutton size again (shoutout old Bootstrap). XL is in there, but it's commented out in the Sass map—just felt like to much to provide out of the box.