Skip to content

New UI components architecture #2012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 27 commits into from
Closed

New UI components architecture #2012

wants to merge 27 commits into from

Conversation

@nimraahmed
Copy link
Contributor

@nimraahmed nimraahmed commented Oct 13, 2023 •
edited by charlesBochet
Loading

Closes #1912

nimraahmed and others added 23 commits October 5, 2023 08:32
@nimraahmed
Added Overview page
5dce29e
@nimraahmed
Revised Getting Started page
0ecb421
@nimraahmed
Minor revision
ea1841d
@nimraahmed
Merge branch 'twentyhq:main' into main
bf376bd
@nimraahmed
Edited readme, minor modifications to docs
77bbb88
@nimraahmed
Removed sweep.yaml, .devcontainer, .ergomake
9872f4e
@nimraahmed
Moved security.md to .github, added contributing.md
a15002b
@nimraahmed
changes as per code review
ef4c46d
@nimraahmed
Merge branch 'twentyhq:main' into main
0ce5aec
@nimraahmed
Merge branch 'twentyhq:main' into main
edb75c0
@nimraahmed
Merge branch 'twentyhq:main' into main
2beca88
@nimraahmed
updated contributing.md
5e55302
@nimraahmed
fixed broken links & added missing links in doc, improved structure
892d73e
@nimraahmed
Merge branch 'twentyhq:main' into main
4335a97
@nimraahmed
fixed link in wsl setup
297e701
@nimraahmed
fixed server link, added https cloning in yarn-setup
4871e77
@nimraahmed
Merge branch 'twentyhq:main' into main
c4d1609
@nimraahmed
removed package-lock.json
4b26fbc
@nimraahmed
added doc card, admonitions
b245366
@nimraahmed
removed underline from nav buttons
9725442
@nimraahmed
Merge branch 'twentyhq:main' into main
48cd8c9
@nimraahmed
refactoring modules/ui
95e900f
@nimraahmed
refactoring modules/ui
a335681
@sweep-ai-deprecated
Copy link
Contributor

sweep-ai-deprecated bot commented Oct 13, 2023

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

@charlesBochet charlesBochet mentioned this pull request Oct 13, 2023
Closed
@charlesBochet charlesBochet changed the title Refactored main --updated branch New UI components architecture Oct 13, 2023
@charlesBochet charlesBochet self-assigned this Oct 13, 2023
charlesBochet
charlesBochet approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@charlesBochet charlesBochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! I've fixed conflicts and changed folder case to respect project convention (kebab-case)

@charlesBochet
Copy link
Member

charlesBochet commented Oct 13, 2023

Duplicate of #2016

@charlesBochet charlesBochet marked this as a duplicate of #2016 Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@charlesBochet charlesBochet charlesBochet approved these changes

Assignees

@charlesBochet charlesBochet

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Reorganize UI components into folders in modules/ui

2 participants

@nimraahmed @charlesBochet