Skip to content

Conversation

@AlfGoto
Copy link
Contributor

@AlfGoto AlfGoto commented Jun 26, 2025

No description provided.

@lattaud lattaud changed the base branch from master to dev June 27, 2025 07:43
@lattaud lattaud self-requested a review June 27, 2025 07:44
@lattaud lattaud self-assigned this Jun 27, 2025
@lattaud lattaud linked an issue Jun 27, 2025 that may be closed by this pull request
Copy link
Collaborator

@lattaud lattaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've gone through the site by building it locally and noticed a one issue:

  • On the French pages under /fr/portfolio/, clicking on PyTurbo or Elixair redirects to the English version of the pages, even though the French URLs (e.g., /fr/portfolio/2023/pyturbo/) do exist.

Aside from that, I just have a few minor comments.

Appart from that I've minor comments on version stability

[languages.fr]
languageName = "Français"
weight = 1
flag = "🇫🇷"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This format is not supported in more recent hugo version

Suggested change
flag = "🇫🇷"
[languages.fr.params]
flag = "🇫🇷"

[languages.en]
languageName = "English"
weight = 2
flag = "🇬🇧"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idem not supported in newer version

Suggested change
flag = "🇬🇧"
[languages.en.params]
flag = "🇬🇧"

Copy link
Collaborator

@lattaud lattaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the modification.
It now looks fine to me !

@lattaud lattaud merged commit 0bef37b into twiinIT:dev Jun 30, 2025
lattaud added a commit that referenced this pull request Jun 30, 2025
* feat: translation

* fix: articles permaLinks, copyright and language flag parameters

* feat: test preview

* fix: preview comment

* chore: removed previews

* fix: useless formats and target blanck

* fix: blogs urls

Co-authored-by: Alf <147511905+AlfGoto@users.noreply.github.com>
lattaud added a commit that referenced this pull request Jun 30, 2025
lattaud added a commit that referenced this pull request Jun 30, 2025
This reverts commit c71df39. 
Some issue were not spotted before deployement.
@lattaud
Copy link
Collaborator

lattaud commented Jun 30, 2025

After deployment some link in the banner menue does not behave properly. In the french menu, if you are either in the teams, service or partner section it link to the english version of the site and not the french one In the portefeuille and blog section thus it behave properly.

lattaud added a commit that referenced this pull request Jun 30, 2025
lattaud added a commit that referenced this pull request Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Site traduction

2 participants