-
Notifications
You must be signed in to change notification settings - Fork 16
feat: translations #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
lattaud
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've gone through the site by building it locally and noticed a one issue:
- On the French pages under /fr/portfolio/, clicking on PyTurbo or Elixair redirects to the English version of the pages, even though the French URLs (e.g., /fr/portfolio/2023/pyturbo/) do exist.
Aside from that, I just have a few minor comments.
Appart from that I've minor comments on version stability
| [languages.fr] | ||
| languageName = "Français" | ||
| weight = 1 | ||
| flag = "🇫🇷" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This format is not supported in more recent hugo version
| flag = "🇫🇷" | |
| [languages.fr.params] | |
| flag = "🇫🇷" |
| [languages.en] | ||
| languageName = "English" | ||
| weight = 2 | ||
| flag = "🇬🇧" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Idem not supported in newer version
| flag = "🇬🇧" | |
| [languages.en.params] | |
| flag = "🇬🇧" |
lattaud
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the modification.
It now looks fine to me !
* feat: translation * fix: articles permaLinks, copyright and language flag parameters * feat: test preview * fix: preview comment * chore: removed previews * fix: useless formats and target blanck * fix: blogs urls Co-authored-by: Alf <147511905+AlfGoto@users.noreply.github.com>
|
After deployment some link in the banner menue does not behave properly. In the french menu, if you are either in the teams, service or partner section it link to the english version of the site and not the french one In the portefeuille and blog section thus it behave properly. |
No description provided.