Skip to content

chore: Updated csharp rc version and changed Request constructor #692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Parent: chore: added custom converters for nested objects (#688)
merged 2 commits into from
Sep 18, 2023
Merged

chore: Updated csharp rc version and changed Request constructor #692

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c5d50dc
chore: Updated csharp rc version and changed Request constructor
tiwarishubham635 Sep 12, 2023
b306d7f
fix: Removed GetParams from Resource interface
tiwarishubham635 Sep 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Twilio/Base/IOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ public interface IOptions<T> where T : Resource
/// </summary>
///
/// <returns>List of parameters for the request</returns>
List<KeyValuePair<string, string>> GetParams();
// List<KeyValuePair<string, string>> GetParams();
}

/// <summary>
Expand Down
9 changes: 8 additions & 1 deletion src/Twilio/Http/Request.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,8 @@ public Request(HttpMethod method, string url)
/// <param name="postParams">Post data</param>
/// <param name="edge">Twilio edge</param>
/// <param name="headerParams">Custom header data</param>
/// <param name="contentType">Content Type</param>
/// <param name="body">Request Body</param>
public Request(
HttpMethod method,
Domain domain,
Expand All @@ -110,7 +112,9 @@ public Request(
List<KeyValuePair<string, string>> queryParams = null,
List<KeyValuePair<string, string>> postParams = null,
string edge = null,
List<KeyValuePair<string, string>> headerParams = null
List<KeyValuePair<string, string>> headerParams = null,
EnumConstants.ContentTypeEnum contentType = null,
string body = null
)
{
Method = method;
Expand All @@ -121,6 +125,9 @@ public Request(
QueryParams = queryParams ?? new List<KeyValuePair<string, string>>();
PostParams = postParams ?? new List<KeyValuePair<string, string>>();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

create a new constructor.
Within request, either postparams will come or body.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot add new constructor due to conflict in other files

HeaderParams = headerParams ?? new List<KeyValuePair<string, string>>();

ContentType = contentType;
Body = body;
}

/// <summary>
Expand Down
2 changes: 1 addition & 1 deletion src/Twilio/Properties/AssemblyInfo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,5 @@

internal class AssemblyInfomation
{
public const string AssemblyInformationalVersion = "6.12.0";
public const string AssemblyInformationalVersion = "7.0.0-rc.0";
}
5 changes: 2 additions & 3 deletions src/Twilio/Twilio.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,8 @@
<Copyright>Copyright © Twilio</Copyright>
<AssemblyTitle>Twilio</AssemblyTitle>
<NeutralLanguage>en-US</NeutralLanguage>
<VersionPrefix>6.12.0</VersionPrefix>
<VersionSuffix>
</VersionSuffix>
<VersionPrefix>7.0.0</VersionPrefix>
<VersionSuffix>rc.0</VersionSuffix>
<Authors>Twilio</Authors>
<NoWarn>$(NoWarn);CS1591</NoWarn>
<GenerateAssemblyInfo>true</GenerateAssemblyInfo>
Expand Down