Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: create BaseClient in Base folder #751

Merged
merged 1 commit into from
Nov 21, 2022

Conversation

rohith-prakash
Copy link
Contributor

Fixes

Creates BaseClient.php which has handcrafted methods separated from Client.php

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

@rohith-prakash rohith-prakash merged commit 9e6bdce into 7.0.0-rc Nov 21, 2022
@rohith-prakash rohith-prakash deleted the 7.0.0-add-baseclient branch November 21, 2022 05:41
isha689 pushed a commit that referenced this pull request Jan 10, 2023
isha689 pushed a commit that referenced this pull request Jan 10, 2023
charan678 added a commit that referenced this pull request Mar 7, 2023
* chore: release candidate and pre-release setup

* chore: create BaseClient in Base folder (#751)

* fix: Add Cluster test (#755)

* chore: add cluster test

* fix: add test files to Rest folder for testing cluster test

* fix: remove yoyodyne generated code from Rest folder

* docs: updated the year in the license

* chore: add rc installation instructions

* fix: add handcrafted domain files with deprecated message for shortcuts (#756)

* fix: base file name (#757)

* chore: removing Integration test suite

* chore: sync up with main branch (#758)

* Delete tests/Twilio/Unit/TwiML/Voice directory

* chore: delete voiceResponseTest.php

* [Librarian] Regenerated @ 82775d167bff9b55d1399fe288c2934a02411e8c

* Release 7.0.0-rc.1

* fix: support array parameters for Guzzle GETs (#759)

* fix: type hint for $capabilities to PhoneNumberCapabilities (#760)

* fix: capabilities dataType to PhoneNumberCapabilities

* fix: __toString() output bool values

* chore: add Deserialization tests for
PhoneNumberCapabilities

* fix: failing test case

* fix: minor change

* chore: remove code smells (#762)

* chore: remove code smells

* fix: ClusterTest

* chore: remove code smells

* chore: remove code smells

* chore: remove code smells

* [Librarian] Regenerated @ a72b955e51d75514f3c944c81b9db17278cfad69

* [Librarian] Regenerated @ b8981cc124150c7112387152deb5f97fb9a25d66

* chore: add examples for calling common apis (#763)

* chore: add examples for calling common apis

* chore: add Voice tests

* fix: correct className

* fix: correct version (#765)

* test: add clientTest

* version fix

* fix: drop removed APIs (#766)

* fix: drop removed APIs

* fix: revert to assertRegExp()

* fix: correct default values for different data types (#768)

* fix: correct indentation and camelCase version (#767)

Co-authored-by: Twilio <team_interfaces+github@twilio.com>

* fix: test failures for PhpUnit >=10 (#769)

* [Librarian] Regenerated @ 6112a581d3189fe96d26eb29eb9adfdbd1c2ada5

* Release 7.0.0-rc.3

* [Librarian] Regenerated @ 17e62aff1baa8b949ed63e888ff63c1da8945fe5

* Release 7.0.0-rc.4

* chore: update upgrade guilde and contribution summary (#764)

Co-authored-by: chsingh <chsingh@twilio.com>

* chore: remove RC changes from Changes.md and Readme.md

* chore: update changes file

* chore: remove newly added integration tests

* chore: remove .open-generator folders/files

---------

Co-authored-by: Isha Bansal <ishabansal2467@gmail.com>
Co-authored-by: Rohith Prakash <rohithprakashklm@gmail.com>
Co-authored-by: Sam Harrison <sharrison@twilio.com>
Co-authored-by: Isha Bansal <55244783+isha689@users.noreply.github.com>
Co-authored-by: Twilio <team_interfaces+github@twilio.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants