Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct default values for different data types #768

Merged
merged 1 commit into from
Feb 7, 2023
Merged

fix: correct default values for different data types #768

merged 1 commit into from
Feb 7, 2023

Conversation

isha689
Copy link
Contributor

@isha689 isha689 commented Feb 2, 2023

Fixes #663

Set the default values for different data types correctly. Previously, for string, bool, int, DateTime the default value had been set as Values:: NONE which is string. Each dataType should have its correct default value. DateTime is set as null because we cannot set an object as a default function/method parameter.

Related PR: twilio/twilio-oai-generator#423

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

@isha689 isha689 mentioned this pull request Feb 2, 2023
Merged
14 tasks
@isha689 isha689 merged commit ebfeea4 into 7.0.0-rc Feb 7, 2023
@isha689 isha689 deleted the default-values branch February 7, 2023 06:10
isha689 added a commit to twilio/twilio-oai-generator that referenced this pull request Feb 7, 2023
@isha689
fix: correct default values for different data types (#423)
e15eec5 
<!--
We appreciate the effort for this pull request but before that please
make sure you read the contribution guidelines, then fill out the blanks
below.

Please format the PR title appropriately based on the type of change:
  <type>[!]: <description>
Where <type> is one of: docs, chore, feat, fix, test, misc.
Add a '!' after the type for breaking changes (e.g. feat!: new breaking
feature).

**All third-party contributors acknowledge that any contributions they
provide will be made under the same open-source license that the
open-source project is provided under.**

Please enter each Issue number you are resolving in your PR after one of
the following words [Fixes, Closes, Resolves]. This will auto-link these
issues and close them when this PR is merged!
e.g.
Fixes #1
Closes #2
-->

# Fixes #

Set the default values for different data types correctly. Previously,
for `string, bool, int, DateTime` the default value had been set as
`Values:: NONE` which is string. Each dataType should have its correct
default value. DateTime is set as null because we cannot set an object
as a default function/method parameter.

Customer issue: [Issue](twilio/twilio-php#663)
Jira Link: [DII-791](https://issues.corp.twilio.com/browse/DII-791)
Related PR: twilio/twilio-php#768

### Checklist
- [x] I acknowledge that all my contributions will be made under the
project's license
- [ ] Run `make test-docker`
- [ ] Verify affected language:
- [ ] Generate [twilio-go](https://github.com/twilio/twilio-go) from our
[OpenAPI specification](https://github.com/twilio/twilio-oai) using the
[build_twilio_go.py](./examples/build_twilio_go.py) using `python
examples/build_twilio_go.py path/to/twilio-oai/spec/yaml
path/to/twilio-go` and inspect the diff
    - [ ] Run `make test` in `twilio-go`
    - [ ] Create a pull request in `twilio-go`
    - [ ] Provide a link below to the pull request
- [ ] I have made a material change to the repo (functionality, testing,
spelling, grammar)
- [ ] I have read the [Contribution
Guidelines](https://github.com/twilio/twilio-oai-generator/blob/main/CONTRIBUTING.md)
and my PR follows them
- [ ] I have titled the PR appropriately
- [ ] I have updated my branch with the main branch
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] I have added the necessary documentation about the functionality
in the appropriate .md file
- [ ] I have added inline documentation to the code I modified

If you have questions, please create a GitHub Issue in this repository.
charan678 added a commit that referenced this pull request Mar 7, 2023
@charan678 @isha689
@rohith-prakash @twilio-dx
feat!: Merge branch '7.0.0-rc' to main (#771)
39c0ec3 
* chore: release candidate and pre-release setup

* chore: create BaseClient in Base folder (#751)

* fix: Add Cluster test (#755)

* chore: add cluster test

* fix: add test files to Rest folder for testing cluster test

* fix: remove yoyodyne generated code from Rest folder

* docs: updated the year in the license

* chore: add rc installation instructions

* fix: add handcrafted domain files with deprecated message for shortcuts (#756)

* fix: base file name (#757)

* chore: removing Integration test suite

* chore: sync up with main branch (#758)

* Delete tests/Twilio/Unit/TwiML/Voice directory

* chore: delete voiceResponseTest.php

* [Librarian] Regenerated @ 82775d167bff9b55d1399fe288c2934a02411e8c

* Release 7.0.0-rc.1

* fix: support array parameters for Guzzle GETs (#759)

* fix: type hint for $capabilities to PhoneNumberCapabilities (#760)

* fix: capabilities dataType to PhoneNumberCapabilities

* fix: __toString() output bool values

* chore: add Deserialization tests for
PhoneNumberCapabilities

* fix: failing test case

* fix: minor change

* chore: remove code smells (#762)

* chore: remove code smells

* fix: ClusterTest

* chore: remove code smells

* chore: remove code smells

* chore: remove code smells

* [Librarian] Regenerated @ a72b955e51d75514f3c944c81b9db17278cfad69

* [Librarian] Regenerated @ b8981cc124150c7112387152deb5f97fb9a25d66

* chore: add examples for calling common apis (#763)

* chore: add examples for calling common apis

* chore: add Voice tests

* fix: correct className

* fix: correct version (#765)

* test: add clientTest

* version fix

* fix: drop removed APIs (#766)

* fix: drop removed APIs

* fix: revert to assertRegExp()

* fix: correct default values for different data types (#768)

* fix: correct indentation and camelCase version (#767)

Co-authored-by: Twilio <team_interfaces+github@twilio.com>

* fix: test failures for PhpUnit >=10 (#769)

* [Librarian] Regenerated @ 6112a581d3189fe96d26eb29eb9adfdbd1c2ada5

* Release 7.0.0-rc.3

* [Librarian] Regenerated @ 17e62aff1baa8b949ed63e888ff63c1da8945fe5

* Release 7.0.0-rc.4

* chore: update upgrade guilde and contribution summary (#764)

Co-authored-by: chsingh <chsingh@twilio.com>

* chore: remove RC changes from Changes.md and Readme.md

* chore: update changes file

* chore: remove newly added integration tests

* chore: remove .open-generator folders/files

---------

Co-authored-by: Isha Bansal <ishabansal2467@gmail.com>
Co-authored-by: Rohith Prakash <rohithprakashklm@gmail.com>
Co-authored-by: Sam Harrison <sharrison@twilio.com>
Co-authored-by: Isha Bansal <55244783+isha689@users.noreply.github.com>
Co-authored-by: Twilio <team_interfaces+github@twilio.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kridai kridai kridai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@isha689 @kridai