fix: test failures for PhpUnit >=10 #769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kridai
approved these changes
Feb 8, 2023
charan678
added a commit
that referenced
this pull request
Mar 7, 2023
* chore: release candidate and pre-release setup * chore: create BaseClient in Base folder (#751) * fix: Add Cluster test (#755) * chore: add cluster test * fix: add test files to Rest folder for testing cluster test * fix: remove yoyodyne generated code from Rest folder * docs: updated the year in the license * chore: add rc installation instructions * fix: add handcrafted domain files with deprecated message for shortcuts (#756) * fix: base file name (#757) * chore: removing Integration test suite * chore: sync up with main branch (#758) * Delete tests/Twilio/Unit/TwiML/Voice directory * chore: delete voiceResponseTest.php * [Librarian] Regenerated @ 82775d167bff9b55d1399fe288c2934a02411e8c * Release 7.0.0-rc.1 * fix: support array parameters for Guzzle GETs (#759) * fix: type hint for $capabilities to PhoneNumberCapabilities (#760) * fix: capabilities dataType to PhoneNumberCapabilities * fix: __toString() output bool values * chore: add Deserialization tests for PhoneNumberCapabilities * fix: failing test case * fix: minor change * chore: remove code smells (#762) * chore: remove code smells * fix: ClusterTest * chore: remove code smells * chore: remove code smells * chore: remove code smells * [Librarian] Regenerated @ a72b955e51d75514f3c944c81b9db17278cfad69 * [Librarian] Regenerated @ b8981cc124150c7112387152deb5f97fb9a25d66 * chore: add examples for calling common apis (#763) * chore: add examples for calling common apis * chore: add Voice tests * fix: correct className * fix: correct version (#765) * test: add clientTest * version fix * fix: drop removed APIs (#766) * fix: drop removed APIs * fix: revert to assertRegExp() * fix: correct default values for different data types (#768) * fix: correct indentation and camelCase version (#767) Co-authored-by: Twilio <team_interfaces+github@twilio.com> * fix: test failures for PhpUnit >=10 (#769) * [Librarian] Regenerated @ 6112a581d3189fe96d26eb29eb9adfdbd1c2ada5 * Release 7.0.0-rc.3 * [Librarian] Regenerated @ 17e62aff1baa8b949ed63e888ff63c1da8945fe5 * Release 7.0.0-rc.4 * chore: update upgrade guilde and contribution summary (#764) Co-authored-by: chsingh <chsingh@twilio.com> * chore: remove RC changes from Changes.md and Readme.md * chore: update changes file * chore: remove newly added integration tests * chore: remove .open-generator folders/files --------- Co-authored-by: Isha Bansal <ishabansal2467@gmail.com> Co-authored-by: Rohith Prakash <rohithprakashklm@gmail.com> Co-authored-by: Sam Harrison <sharrison@twilio.com> Co-authored-by: Isha Bansal <55244783+isha689@users.noreply.github.com> Co-authored-by: Twilio <team_interfaces+github@twilio.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Some methods have been deprecated and removed in PhpUnit 10 including
assertObjectNotHasAttribute(),assertRegExp()Replacing these methods with their alternatives will lead to test failures for Php 7.2 because PHP 7.2 requires PhpUnit 8.5 and the alternative
assertMatchesRegularExpression()forassertRegExp()is not supported by phpUnit 8.5Checklist
If you have questions, please file a support ticket, or create a GitHub Issue in this repository.