fix: type hint for $capabilities to PhoneNumberCapabilities #760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
isha689
added a commit
to twilio/twilio-oai-generator
that referenced
this pull request
Jan 24, 2023
<!-- We appreciate the effort for this pull request but before that please make sure you read the contribution guidelines, then fill out the blanks below. Please format the PR title appropriately based on the type of change: <type>[!]: <description> Where <type> is one of: docs, chore, feat, fix, test, misc. Add a '!' after the type for breaking changes (e.g. feat!: new breaking feature). **All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.** Please enter each Issue number you are resolving in your PR after one of the following words [Fixes, Closes, Resolves]. This will auto-link these issues and close them when this PR is merged! e.g. Fixes #1 Closes #2 --> # Fixes # Fixes [php-issue](twilio/twilio-php#627) Ref: [PR](twilio/twilio-php#760) Made changes in Dockerfile because the generated src folder will depend on [Deserialize:: phoneNumberCapabilities()](https://github.com/twilio/twilio-php/blob/DII-790/src/Twilio/Deserialize.php#L34) which is to be merged into rc-branch. **Note: Dockerfile changes to be reverted before MVR release** ### Checklist - [x] I acknowledge that all my contributions will be made under the project's license - [ ] Run `make test-docker` - [ ] Verify affected language: - [ ] Generate [twilio-go](https://github.com/twilio/twilio-go) from our [OpenAPI specification](https://github.com/twilio/twilio-oai) using the [build_twilio_go.py](./examples/build_twilio_go.py) using `python examples/build_twilio_go.py path/to/twilio-oai/spec/yaml path/to/twilio-go` and inspect the diff - [ ] Run `make test` in `twilio-go` - [ ] Create a pull request in `twilio-go` - [ ] Provide a link below to the pull request - [ ] I have made a material change to the repo (functionality, testing, spelling, grammar) - [ ] I have read the [Contribution Guidelines](https://github.com/twilio/twilio-oai-generator/blob/main/CONTRIBUTING.md) and my PR follows them - [ ] I have titled the PR appropriately - [ ] I have updated my branch with the main branch - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have added the necessary documentation about the functionality in the appropriate .md file - [ ] I have added inline documentation to the code I modified If you have questions, please create a GitHub Issue in this repository.
shrutiburman
added a commit
to twilio/twilio-oai-generator
that referenced
this pull request
Jan 29, 2023
commit 881c2c2 Author: childish-sambino <sharrison@twilio.com> Date: Fri Jan 27 16:15:49 2023 -0600 test: look for all services, including those that are stopped, when checking status (#416) commit 111ef95 Author: childish-sambino <sharrison@twilio.com> Date: Fri Jan 27 14:55:59 2023 -0600 fix: move lib to src and dist to lib for node backwards-compatibility (#415) commit a0b4320 Author: Isha Bansal <55244783+isha689@users.noreply.github.com> Date: Fri Jan 27 20:20:56 2023 +0530 fix: set correct type for response properties (#409) <!-- We appreciate the effort for this pull request but before that please make sure you read the contribution guidelines, then fill out the blanks below. Please format the PR title appropriately based on the type of change: <type>[!]: <description> Where <type> is one of: docs, chore, feat, fix, test, misc. Add a '!' after the type for breaking changes (e.g. feat!: new breaking feature). **All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.** Please enter each Issue number you are resolving in your PR after one of the following words [Fixes, Closes, Resolves]. This will auto-link these issues and close them when this PR is merged! e.g. Fixes #1 Closes #2 --> # Fixes [#727](twilio/twilio-php#727) Set correct dataType for nullable response properties. Jira link: https://issues.corp.twilio.com/browse/DII-789 ### Checklist - [x] I acknowledge that all my contributions will be made under the project's license - [ ] Run `make test-docker` - [ ] Verify affected language: - [ ] Generate [twilio-go](https://github.com/twilio/twilio-go) from our [OpenAPI specification](https://github.com/twilio/twilio-oai) using the [build_twilio_go.py](./examples/build_twilio_go.py) using `python examples/build_twilio_go.py path/to/twilio-oai/spec/yaml path/to/twilio-go` and inspect the diff - [ ] Run `make test` in `twilio-go` - [ ] Create a pull request in `twilio-go` - [ ] Provide a link below to the pull request - [ ] I have made a material change to the repo (functionality, testing, spelling, grammar) - [ ] I have read the [Contribution Guidelines](https://github.com/twilio/twilio-oai-generator/blob/main/CONTRIBUTING.md) and my PR follows them - [ ] I have titled the PR appropriately - [ ] I have updated my branch with the main branch - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have added the necessary documentation about the functionality in the appropriate .md file - [ ] I have added inline documentation to the code I modified If you have questions, please create a GitHub Issue in this repository. commit 780dd25 Author: Isha Bansal <55244783+isha689@users.noreply.github.com> Date: Fri Jan 27 10:25:53 2023 +0530 fix: trailing comma (#414) <!-- We appreciate the effort for this pull request but before that please make sure you read the contribution guidelines, then fill out the blanks below. Please format the PR title appropriately based on the type of change: <type>[!]: <description> Where <type> is one of: docs, chore, feat, fix, test, misc. Add a '!' after the type for breaking changes (e.g. feat!: new breaking feature). **All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.** Please enter each Issue number you are resolving in your PR after one of the following words [Fixes, Closes, Resolves]. This will auto-link these issues and close them when this PR is merged! e.g. Fixes #1 Closes #2 --> # Fixes # Removed the trailing comma within the function call. Correct alignment of braces. Cluster Tests successful run: [here](https://github.com/twilio/twilio-php/actions/runs/4014524180) ### Checklist - [x] I acknowledge that all my contributions will be made under the project's license - [ ] Run `make test-docker` - [ ] Verify affected language: - [ ] Generate [twilio-go](https://github.com/twilio/twilio-go) from our [OpenAPI specification](https://github.com/twilio/twilio-oai) using the [build_twilio_go.py](./examples/build_twilio_go.py) using `python examples/build_twilio_go.py path/to/twilio-oai/spec/yaml path/to/twilio-go` and inspect the diff - [ ] Run `make test` in `twilio-go` - [ ] Create a pull request in `twilio-go` - [ ] Provide a link below to the pull request - [ ] I have made a material change to the repo (functionality, testing, spelling, grammar) - [ ] I have read the [Contribution Guidelines](https://github.com/twilio/twilio-oai-generator/blob/main/CONTRIBUTING.md) and my PR follows them - [ ] I have titled the PR appropriately - [ ] I have updated my branch with the main branch - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have added the necessary documentation about the functionality in the appropriate .md file - [ ] I have added inline documentation to the code I modified If you have questions, please create a GitHub Issue in this repository. commit 371df1c Author: Claudia Chua <43133161+claudiachua@users.noreply.github.com> Date: Thu Jan 26 09:11:10 2023 +0800 fix: remove camelcase duplicates domains (#413) commit c2b17aa Author: cchua <cchua@twilio.com> Date: Thu Jan 26 04:04:46 2023 +0800 revert last commit commit ca3adc4 Author: cchua <cchua@twilio.com> Date: Thu Jan 26 04:01:50 2023 +0800 fix: remove camelcase duplicates domains commit 8d060e2 Author: Rohith Prakash <rohithprakashklm@gmail.com> Date: Wed Jan 25 17:15:14 2023 +0530 chore: Ruby add Page template (#412) <!-- We appreciate the effort for this pull request but before that please make sure you read the contribution guidelines, then fill out the blanks below. Please format the PR title appropriately based on the type of change: <type>[!]: <description> Where <type> is one of: docs, chore, feat, fix, test, misc. Add a '!' after the type for breaking changes (e.g. feat!: new breaking feature). **All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.** Please enter each Issue number you are resolving in your PR after one of the following words [Fixes, Closes, Resolves]. This will auto-link these issues and close them when this PR is merged! e.g. Fixes #1 Closes #2 --> # Chore # Adds ruby page class template ### Checklist - [x] I acknowledge that all my contributions will be made under the project's license - [ ] Run `make test-docker` - [ ] Verify affected language: - [ ] Generate [twilio-go](https://github.com/twilio/twilio-go) from our [OpenAPI specification](https://github.com/twilio/twilio-oai) using the [build_twilio_go.py](./examples/build_twilio_go.py) using `python examples/build_twilio_go.py path/to/twilio-oai/spec/yaml path/to/twilio-go` and inspect the diff - [ ] Run `make test` in `twilio-go` - [ ] Create a pull request in `twilio-go` - [ ] Provide a link below to the pull request - [ ] I have made a material change to the repo (functionality, testing, spelling, grammar) - [ ] I have read the [Contribution Guidelines](https://github.com/twilio/twilio-oai-generator/blob/main/CONTRIBUTING.md) and my PR follows them - [ ] I have titled the PR appropriately - [ ] I have updated my branch with the main branch - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have added the necessary documentation about the functionality in the appropriate .md file - [ ] I have added inline documentation to the code I modified If you have questions, please create a GitHub Issue in this repository. commit 6ed2a9f Author: Isha Bansal <55244783+isha689@users.noreply.github.com> Date: Tue Jan 24 16:58:13 2023 +0530 fix: type hint for $capabilities to PhoneNumberCapabilities (#404) <!-- We appreciate the effort for this pull request but before that please make sure you read the contribution guidelines, then fill out the blanks below. Please format the PR title appropriately based on the type of change: <type>[!]: <description> Where <type> is one of: docs, chore, feat, fix, test, misc. Add a '!' after the type for breaking changes (e.g. feat!: new breaking feature). **All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.** Please enter each Issue number you are resolving in your PR after one of the following words [Fixes, Closes, Resolves]. This will auto-link these issues and close them when this PR is merged! e.g. Fixes #1 Closes #2 --> # Fixes # Fixes [php-issue](twilio/twilio-php#627) Ref: [PR](twilio/twilio-php#760) Made changes in Dockerfile because the generated src folder will depend on [Deserialize:: phoneNumberCapabilities()](https://github.com/twilio/twilio-php/blob/DII-790/src/Twilio/Deserialize.php#L34) which is to be merged into rc-branch. **Note: Dockerfile changes to be reverted before MVR release** ### Checklist - [x] I acknowledge that all my contributions will be made under the project's license - [ ] Run `make test-docker` - [ ] Verify affected language: - [ ] Generate [twilio-go](https://github.com/twilio/twilio-go) from our [OpenAPI specification](https://github.com/twilio/twilio-oai) using the [build_twilio_go.py](./examples/build_twilio_go.py) using `python examples/build_twilio_go.py path/to/twilio-oai/spec/yaml path/to/twilio-go` and inspect the diff - [ ] Run `make test` in `twilio-go` - [ ] Create a pull request in `twilio-go` - [ ] Provide a link below to the pull request - [ ] I have made a material change to the repo (functionality, testing, spelling, grammar) - [ ] I have read the [Contribution Guidelines](https://github.com/twilio/twilio-oai-generator/blob/main/CONTRIBUTING.md) and my PR follows them - [ ] I have titled the PR appropriately - [ ] I have updated my branch with the main branch - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have added the necessary documentation about the functionality in the appropriate .md file - [ ] I have added inline documentation to the code I modified If you have questions, please create a GitHub Issue in this repository. commit fee7ea3 Author: Charanjeet Singh <chsingh@twilio.com> Date: Tue Jan 24 13:15:49 2023 +0530 fix: Php lint issues (#411) <!-- We appreciate the effort for this pull request but before that please make sure you read the contribution guidelines, then fill out the blanks below. Please format the PR title appropriately based on the type of change: <type>[!]: <description> Where <type> is one of: docs, chore, feat, fix, test, misc. Add a '!' after the type for breaking changes (e.g. feat!: new breaking feature). **All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.** Please enter each Issue number you are resolving in your PR after one of the following words [Fixes, Closes, Resolves]. This will auto-link these issues and close them when this PR is merged! e.g. Fixes #1 Closes #2 --> # Fixes # - Fix sonar lint issues for php generated example files - Fix php template files and generated path string from phpAPIBuilder ### Checklist - [x] I acknowledge that all my contributions will be made under the project's license - [ ] Run `make test-docker` - [ ] Verify affected language: - [ ] Generate [twilio-go](https://github.com/twilio/twilio-go) from our [OpenAPI specification](https://github.com/twilio/twilio-oai) using the [build_twilio_go.py](./examples/build_twilio_go.py) using `python examples/build_twilio_go.py path/to/twilio-oai/spec/yaml path/to/twilio-go` and inspect the diff - [ ] Run `make test` in `twilio-go` - [ ] Create a pull request in `twilio-go` - [ ] Provide a link below to the pull request - [ ] I have made a material change to the repo (functionality, testing, spelling, grammar) - [ ] I have read the [Contribution Guidelines](https://github.com/twilio/twilio-oai-generator/blob/main/CONTRIBUTING.md) and my PR follows them - [ ] I have titled the PR appropriately - [ ] I have updated my branch with the main branch - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have added the necessary documentation about the functionality in the appropriate .md file - [ ] I have added inline documentation to the code I modified If you have questions, please create a GitHub Issue in this repository. commit 78d623d Author: childish-sambino <sharrison@twilio.com> Date: Fri Jan 20 09:51:28 2023 -0600 fix: refactor API filename generation for ruby (#408) Node examples are currently broken. This fixes it.
charan678
added a commit
that referenced
this pull request
Mar 7, 2023
* chore: release candidate and pre-release setup * chore: create BaseClient in Base folder (#751) * fix: Add Cluster test (#755) * chore: add cluster test * fix: add test files to Rest folder for testing cluster test * fix: remove yoyodyne generated code from Rest folder * docs: updated the year in the license * chore: add rc installation instructions * fix: add handcrafted domain files with deprecated message for shortcuts (#756) * fix: base file name (#757) * chore: removing Integration test suite * chore: sync up with main branch (#758) * Delete tests/Twilio/Unit/TwiML/Voice directory * chore: delete voiceResponseTest.php * [Librarian] Regenerated @ 82775d167bff9b55d1399fe288c2934a02411e8c * Release 7.0.0-rc.1 * fix: support array parameters for Guzzle GETs (#759) * fix: type hint for $capabilities to PhoneNumberCapabilities (#760) * fix: capabilities dataType to PhoneNumberCapabilities * fix: __toString() output bool values * chore: add Deserialization tests for PhoneNumberCapabilities * fix: failing test case * fix: minor change * chore: remove code smells (#762) * chore: remove code smells * fix: ClusterTest * chore: remove code smells * chore: remove code smells * chore: remove code smells * [Librarian] Regenerated @ a72b955e51d75514f3c944c81b9db17278cfad69 * [Librarian] Regenerated @ b8981cc124150c7112387152deb5f97fb9a25d66 * chore: add examples for calling common apis (#763) * chore: add examples for calling common apis * chore: add Voice tests * fix: correct className * fix: correct version (#765) * test: add clientTest * version fix * fix: drop removed APIs (#766) * fix: drop removed APIs * fix: revert to assertRegExp() * fix: correct default values for different data types (#768) * fix: correct indentation and camelCase version (#767) Co-authored-by: Twilio <team_interfaces+github@twilio.com> * fix: test failures for PhpUnit >=10 (#769) * [Librarian] Regenerated @ 6112a581d3189fe96d26eb29eb9adfdbd1c2ada5 * Release 7.0.0-rc.3 * [Librarian] Regenerated @ 17e62aff1baa8b949ed63e888ff63c1da8945fe5 * Release 7.0.0-rc.4 * chore: update upgrade guilde and contribution summary (#764) Co-authored-by: chsingh <chsingh@twilio.com> * chore: remove RC changes from Changes.md and Readme.md * chore: update changes file * chore: remove newly added integration tests * chore: remove .open-generator folders/files --------- Co-authored-by: Isha Bansal <ishabansal2467@gmail.com> Co-authored-by: Rohith Prakash <rohithprakashklm@gmail.com> Co-authored-by: Sam Harrison <sharrison@twilio.com> Co-authored-by: Isha Bansal <55244783+isha689@users.noreply.github.com> Co-authored-by: Twilio <team_interfaces+github@twilio.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #627
Type hint for $capabilities had been set as
string, while open_api_spec specifies the type to be anobjectwith boolean properties.Jira ticket: link
Checklist
If you have questions, please file a support ticket, or create a GitHub Issue in this repository.