Skip to content

Conversation

@obany
Copy link
Contributor

@obany obany commented Jan 21, 2026

📝 Description

Adds missing JSON-LD context metadata for framework and JSON-LD data type registrations, and updates the related context constants and reference docs.

🔄 Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 Documentation update
  • ⚡ Performance improvement
  • ♻️ Code refactoring
  • 📦 Dependencies update

🛠️ Changes Made

  • Add Context and JsonLdContext entries to framework and JSON-LD context constants
  • Include jsonLdContext when registering framework data types
  • Pass JsonLdContexts.JsonLdContext to DataTypeHelper.registerTypes instead of undefined
  • Update generated reference docs for the context constants

🧪 Testing

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have tested this change manually
  • Testing not required for changes

@obany obany merged commit 9d99360 into next Jan 21, 2026
2 checks passed
@gemini-code-assist
Copy link

Summary of Changes

Hello @obany, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the handling of JSON-LD contexts within the system by introducing dedicated constants for framework and JSON-LD data types. These changes ensure that data type registrations are more precise with their associated JSON-LD metadata, improving data interoperability and consistency. Additionally, the corresponding documentation has been updated, and various development dependencies have been refreshed to their latest versions.

Highlights

  • JSON-LD Context Enhancement: Introduced new Context and JsonLdContext constants within both Framework and JSON-LD context definitions to provide more explicit metadata for data type registrations.
  • Data Type Registration Update: Modified the data type registration process to correctly include the jsonLdContext when registering framework data types and explicitly pass JsonLdContexts.JsonLdContext for JSON-LD data types, replacing previous undefined values.
  • Documentation Updates: Updated the generated reference documentation for FrameworkContexts and JsonLdContexts to reflect the newly added context constants and their descriptions.
  • Dependency Updates: Numerous development dependencies have been updated across various packages, including @babel, @commitlint, @cspell, @esbuild, @shikijs, @twin.org, @types, esbuild, eslint, prettier, typescript, and vite, among others. Several peer dependency declarations were also removed from package-lock.json.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions github-actions bot mentioned this pull request Jan 21, 2026
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request successfully implements the changes described, adding missing JSON-LD context metadata for framework and JSON-LD data type registrations. The related context constants and reference documentation have been updated accordingly. The dependency updates in package-lock.json are standard version bumps and do not introduce any issues. Overall, the changes improve the clarity and completeness of the JSON-LD context handling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants