Parser tests #13
Merged
Parser tests #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
package.json
Outdated
| "url": "git://github.com/twingly/twingly-search-api-node.git" | ||
| }, | ||
| "dependencies": { | ||
| "chai-datetime": "^1.4.0", |
Contributor
There was a problem hiding this comment.
shouldn't these be dev dependencies?
Contributor
Author
There was a problem hiding this comment.
Indeed they should, I used --save when I should have used --save-dev, will fix, thanks
Contributor
|
LGTM |
1s -> ~500ms
test/test_result.js
Outdated
| it('creation', function(done){ | ||
| var data = fs.readFileSync('./test/fixtures/valid_result.xml', {encoding: 'utf8'}); | ||
| (new Parser()).parse(data, function(error, result){ | ||
| expect(result).to.be.instanceof(Result); |
Contributor
There was a problem hiding this comment.
Don't think this is needed here, the point is not to check the return value of the parser but to assert that we find certain properties on the Result type (this is a test for Result).
Contributor
Author
There was a problem hiding this comment.
Yes, that makes sense, thanks.
> Don't think this is needed here, the point is not to check the return > value of the parser but to assert that we find certain properties on > the Result type (this is a test for Result).
Contributor
|
LGTM again :D |
Contributor
Author
|
😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test the parser in the same fashion as twingly/twingly-search-api-ruby#49