Closed
Conversation
Member
|
For now we won't be adding this. I'd like to keep our icons as simple as possible and we're already bordering too complex unfortunately. |
Contributor
Author
|
Cool, NP. Just that I have noticed one or two folks were having a problem with this, so decided to chalk out a possible solution. It might be nice to support this later on, as glyphicons don't have every icon needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ideally, a custom icon should be as easy to add as
Apparently, this used to work in 2.0.4, but no longer works in 2.1.0 - someone reported this in the mailing group. The issue is that the bootstrap styles in many elements have more specificity now, such as
which makes the browser pick that particular background image (mentioned in the property).
I have been thinking of some solutions and the best I could think of was to have a separate class prefix, like
I have added support for using this approach in the commit.
Would love to hear/know about any alternate approaches possible.