Audit fixes #52
Merged
Audit fixes #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredevery
force-pushed
the
swap-to-webpack
branch
2 times, most recently
from
08fe119 to
755b51d
Compare
fredevery
force-pushed
the
swap-to-webpack
branch
from
755b51d to
65dc6fd
Compare
LevKanter
approved these changes
Jun 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings in quite a lot of infrastructural changes for the development environment.
The first of which is to swap out rollup in favour of webpack for building the app as well as running the dev server.
The second is a swap out of nightwatch in favour of cypress. All the e2e tests that were run through nightwatch have been rewritten for the cypress runner and are now in
/test/integrationThe third, and the instigating issue for this PR, is swapping out the
karma-jasmine-jquerypackage in favour ofkarma-jquery. The former package suffered from some high and critical errors according the npm audit. Note the project now has 0 npm audit issues.The README has also been updated to reflect the changes.
Note as a side effect of migrating to webpack this project no longer requires docker or docker-compose.