Move incremental output to OS temp

Author: dfreeman

blueprints/ember-cli-typescript/index.js

@@ -38,22 +38,6 @@ module.exports = {
   },
 
   afterInstall() {
-    if (existsSync('.gitignore')) {
-      this.insertIntoFile('.gitignore', '\n# Ember CLI TypeScript\n.e-c-ts');
-    }
-
-    if (existsSync('.vscode/settings.json')) {
-      // NOTE: this may or may not actually work -- it assumes that
-      // `"tmp:": true` is in fact set.
-      this.insertIntoFile('.vscode/settings.json', '",\n.e-c-ts": true', {
-        after: '"tmp": true',
-      });
-    }
-
-    // TODO: same for Atom
-    // TODO: same for Sublime
-    // TODO: same for IntelliJ
-
     return this.addPackagesToProject([
       { name: 'typescript', target: 'latest' },
       { name: '@types/ember', target: 'latest' },

index.js

@@ -2,6 +2,7 @@
 /* eslint-env node */
 
 const fs = require('fs');
+const os = require('os');
 const path = require('path');
 const SilentError = require('silent-error');
 const TsPreprocessor = require('./lib/typescript-preprocessor');
@@ -17,6 +18,16 @@ module.exports = {
     return this.project._isRunningServeTS;
   },
 
+  _tempDir() {
+    if (!this.project._tsTempDir) {
+      const tempDir = path.join(os.tmpdir(), `e-c-ts-${process.pid}`);
+      this.project._tsTempDir = tempDir;
+      mkdirp.sync(tempDir);
+    }
+
+    return this.project._tsTempDir;
+  },
+
   _inRepoAddons() {
     const pkg = this.project.pkg;
     if (!pkg || !pkg['ember-addon'] || !pkg['ember-addon'].paths) {
@@ -28,7 +39,7 @@ module.exports = {
 
   includedCommands() {
     return {
-      'serve-ts': buildServeCommand(this.project),
+      'serve-ts': buildServeCommand(this.project, this._tempDir()),
     };
   },
 
@@ -75,10 +86,10 @@ module.exports = {
 
     // funnel will fail if the directory doesn't exist
     roots.forEach(root => {
-      mkdirp.sync(path.join('.e-c-ts', root));
+      mkdirp.sync(path.join(this._tempDir(), root));
     });
 
-    const ts = funnel('.e-c-ts', {
+    const ts = funnel(this._tempDir(), {
       exclude: ['tests'],
       getDestinationPath(relativePath) {
         const prefix = roots.find(root => relativePath.startsWith(root));
@@ -99,7 +110,7 @@ module.exports = {
       return tree;
     }
 
-    const tests = path.join('.e-c-ts', 'tests');
+    const tests = path.join(this._tempDir(), 'tests');
 
     // funnel will fail if the directory doesn't exist
     mkdirp.sync(tests);

lib/serve-ts.js

@@ -5,9 +5,8 @@ const child_process = require('child_process');
 const fs = require('fs');
 
 const rimraf = require('rimraf');
-const OUT_DIR = '.e-c-ts';
 
-module.exports = (project) => {
+module.exports = (project, outDir) => {
   const Serve = project.require('ember-cli/lib/commands/serve');
   const Builder = project.require('ember-cli/lib/models/builder');
   const Watcher = project.require('ember-cli/lib/models/watcher');
@@ -71,7 +70,7 @@ module.exports = (project) => {
         'node_modules/typescript/bin/tsc',
         [
           '--watch',
-          '--outDir', OUT_DIR,
+          '--outDir', outDir,
           '--allowJs', 'false',
           '--noEmit', 'false',
           '--sourceMap', 'false', // TODO: enable if sourcemaps=true
@@ -97,8 +96,8 @@ module.exports = (project) => {
           this.tsc.kill();
         }
 
-        if (fs.existsSync(OUT_DIR)) {
-          rimraf.sync(OUT_DIR);
+        if (fs.existsSync(outDir)) {
+          rimraf.sync(outDir);
         }
       });
     },