Fix addon order for generators when usign ember-decorators #235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamescdavis
approved these changes
Jul 19, 2018
Member
jamescdavis
left a comment
jamescdavis
left a comment
There was a problem hiding this comment.
Confirmed this fixes the issue with ember-decorators' blueprints overriding ember-cli-typescript. I'm pretty certain this fixes #233 because the generated service documented in that issue matches the ember-decorators service blueprint (and not the "ember-cli" service blueprint, which actually lives in ember-source).
dfreeman
pushed a commit
that referenced
this pull request
Aug 21, 2018
Fix addon order for generators when usign ember-decorators
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
ember-decoratorsproject in combination with typescript, the generators from the decorators was taking precedence of the generators from typescript. This fixes it.This might fix #233.