Skip to content

Commit 081a6f0

Browse files
authored
Remove incompatible native.maven_jar usage (#127)
Bazel 2.0 removes `maven_jar` from native rules. In order for us to migrate to newer Bazel, `checkstyle_dependencies` need to be adapted according to guide in bazelbuild/bazel#6799
1 parent ab6e79d commit 081a6f0

File tree

1 file changed

+39
-9
lines changed

1 file changed

+39
-9
lines changed

checkstyle/dependencies.bzl

Lines changed: 39 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,9 @@
1616
# along with this program. If not, see <https://www.gnu.org/licenses/>.
1717
#
1818

19+
load("@bazel_tools//tools/build_defs/repo:jvm.bzl", "jvm_maven_import_external")
20+
21+
1922
def checkstyle_dependencies(
2023
omit = [],
2124
versions = {
@@ -31,47 +34,74 @@ def checkstyle_dependencies(
3134
}
3235
):
3336
if not "antlr_antlr" in omit:
34-
native.maven_jar(
37+
jvm_maven_import_external(
3538
name = "antlr_antlr",
3639
artifact = "antlr:antlr:" + versions["antlr_antlr"],
40+
artifact_sha256 = "88fbda4b912596b9f56e8e12e580cc954bacfb51776ecfddd3e18fc1cf56dc4c",
41+
server_urls = ["https://repo1.maven.org/maven2/"],
42+
licenses = ["notice"],
3743
)
3844
if not "org_antlr_antlr4_runtime" in omit:
39-
native.maven_jar(
45+
jvm_maven_import_external(
4046
name = "org_antlr_antlr4_runtime",
4147
artifact = "org.antlr:antlr4-runtime:" + versions["org_antlr_antlr4_runtime"],
48+
artifact_sha256 = "ffca72bc2a25bb2b0c80a58cee60530a78be17da739bb6c91a8c2e3584ca099e",
49+
server_urls = ["https://repo1.maven.org/maven2/"],
50+
licenses = ["notice"],
4251
)
4352
if not "com_puppycrawl_tools_checkstyle" in omit:
44-
native.maven_jar(
53+
jvm_maven_import_external(
4554
name = "com_puppycrawl_tools_checkstyle",
4655
artifact = "com.puppycrawl.tools:checkstyle:" + versions["com_puppycrawl_tools_checkstyle"],
56+
artifact_sha256 = "ac3602c4d50c3113b14614a6ac38ec03c63d9839e4316e057c4bb66d97183087",
57+
server_urls = ["https://repo1.maven.org/maven2/"],
58+
licenses = ["notice"],
4759
)
4860
if not "commons_beanutils_commons_beanutils" in omit:
49-
native.maven_jar(
61+
jvm_maven_import_external(
5062
name = "commons_beanutils_commons_beanutils",
5163
artifact = "commons-beanutils:commons-beanutils:" + versions["commons_beanutils_commons_beanutils"],
64+
artifact_sha256 = "c058e39c7c64203d3a448f3adb588cb03d6378ed808485618f26e137f29dae73",
65+
server_urls = ["https://repo1.maven.org/maven2/"],
66+
licenses = ["notice"],
5267
)
5368
if not "info_picocli_picocli" in omit:
54-
native.maven_jar(
69+
jvm_maven_import_external(
5570
name = "info_picocli_picocli",
5671
artifact = "info.picocli:picocli:" + versions["info_picocli_picocli"],
72+
artifact_sha256 = "b16786a3817530151ccc44ac44f1f803b9a1b4069e98c4d1ed2fc0ece12d6de7",
73+
server_urls = ["https://repo1.maven.org/maven2/"],
74+
licenses = ["notice"],
5775
)
5876
if not "commons_collections_commons_collections" in omit:
59-
native.maven_jar(
77+
jvm_maven_import_external(
6078
name = "commons_collections_commons_collections",
6179
artifact = "commons-collections:commons-collections:" + versions["commons_collections_commons_collections"],
80+
artifact_sha256 = "eeeae917917144a68a741d4c0dff66aa5c5c5fd85593ff217bced3fc8ca783b8",
81+
server_urls = ["https://repo1.maven.org/maven2/"],
82+
licenses = ["notice"],
6283
)
6384
if not "com_google_guava_guava23" in omit:
64-
native.maven_jar(
85+
jvm_maven_import_external(
6586
name = "com_google_guava_guava23",
6687
artifact = "com.google.guava:guava:" + versions["com_google_guava_guava23"],
88+
artifact_sha256 = "7baa80df284117e5b945b19b98d367a85ea7b7801bd358ff657946c3bd1b6596",
89+
server_urls = ["https://repo1.maven.org/maven2/"],
90+
licenses = ["notice"],
6791
)
6892
if not "org_slf4j_slf4j_api" in omit:
69-
native.maven_jar(
93+
jvm_maven_import_external(
7094
name = "org_slf4j_slf4j_api",
7195
artifact = "org.slf4j:slf4j-api:" + versions["org_slf4j_slf4j_api"],
96+
artifact_sha256 = "69980c038ca1b131926561591617d9c25fabfc7b29828af91597ca8570cf35fe",
97+
server_urls = ["https://repo1.maven.org/maven2/"],
98+
licenses = ["notice"],
7299
)
73100
if not "org_slf4j_slf4j_jcl" in omit:
74-
native.maven_jar(
101+
jvm_maven_import_external(
75102
name = "org_slf4j_slf4j_jcl",
76103
artifact = "org.slf4j:jcl-over-slf4j:" + versions["org_slf4j_slf4j_jcl"],
104+
artifact_sha256 = "c6472b5950e1c23202e567c6334e4832d1db46fad604b7a0d7af71d4a014bce2",
105+
server_urls = ["https://repo1.maven.org/maven2/"],
106+
licenses = ["notice"],
77107
)

0 commit comments

Comments
 (0)