Dependencies and rules refactoring for the C# driver deployment (#521)

## What is the goal of this PR?

We prepare tools for the C# driver release, namely and clean all the old
TODOs left from the initial PR.

## What are the changes implemented in this PR?

Added:
* nuget deployment URLs for referencing from the C# bazel rules.

Updated:
* Refactored the bazel rule for native C# library generation. Cleaned
TODOs.

Author: farost

builder/swig/csharp.bzl

@@ -3,9 +3,6 @@
 # file, You can obtain one at https://mozilla.org/MPL/2.0/.
 
 
-# TODO: Generalise and move the same functions (used by java, python, csharp)
-# to a base file, add reusage where possible.
-
 load("@rules_dotnet//dotnet:defs.bzl", "csharp_library")
 load("@rules_dotnet//dotnet/private:providers.bzl", "DotnetAssemblyCompileInfo", "DotnetAssemblyRuntimeInfo")
 
@@ -98,7 +95,7 @@ swig_csharp_wrapper = rule(
             allow_files = True,
         ),
         "namespace": attr.string(
-            doc = "C# namespace where to put the sources",
+            doc = "C# namespace for the sources",
             mandatory = True,
         ),
         "enable_cxx": attr.bool(
@@ -157,18 +154,16 @@ csharp_native_library = rule(
 )
 
 
-def swig_csharp(name, lib, nullable_context, target_frameworks, targeting_packs, shared_lib_name=None, tags=[], **kwargs):
+def swig_csharp(name, native_lib_name, lib, namespace, nullable_context, target_frameworks, targeting_packs, tags=[], **kwargs):
     swig_wrapper_name = "{}_swig".format(name)
     swig_csharp_wrapper(
         name = swig_wrapper_name,
         class_name = name,
         lib = lib,
+        namespace = namespace,
         **kwargs,
     )
 
-    if not shared_lib_name:
-        shared_lib_name = name
-
     def swig_cc_binary(shared_lib_filename):
         # name doesn't accept select() either
         native.cc_binary(
@@ -183,22 +178,16 @@ def swig_csharp(name, lib, nullable_context, target_frameworks, targeting_packs,
             }),
         )
 
-    native_lib_name_root = "typedb_driver"
-    native_lib_name = "{}_native".format(native_lib_name_root)
-
-    # TODO: On Mac, it's enough to pass native_lib_name_root (lib and .dylib are added by the rule)
-    # Check if the same could work for Windows and Linux. Maybe we don't need to make
-    # this complex code with selects and functions...
-    swig_cc_binary("lib" + native_lib_name_root + ".dylib")
-    swig_cc_binary("lib" + native_lib_name_root + ".so")
-    swig_cc_binary(native_lib_name_root + ".dll")
+    swig_cc_binary("lib" + native_lib_name + ".dylib")
+    swig_cc_binary("lib" + native_lib_name + ".so")
+    swig_cc_binary(native_lib_name + ".dll")
 
     native.alias(
         name = native_lib_name,
         actual = select({
-            "@vaticle_bazel_distribution//platform:is_mac": ("lib" + native_lib_name_root + ".dylib"),
-            "@vaticle_bazel_distribution//platform:is_linux": ("lib" + native_lib_name_root + ".so"),
-            "@vaticle_bazel_distribution//platform:is_windows": (native_lib_name_root + ".dll"),
+            "@vaticle_bazel_distribution//platform:is_mac": ("lib" + native_lib_name + ".dylib"),
+            "@vaticle_bazel_distribution//platform:is_linux": ("lib" + native_lib_name + ".so"),
+            "@vaticle_bazel_distribution//platform:is_windows": (native_lib_name + ".dll"),
         })
     )
 
@@ -221,6 +210,7 @@ def swig_csharp(name, lib, nullable_context, target_frameworks, targeting_packs,
         name = name,
         srcs = [":{}".format(csharp_source_name)],
         deps = [":{}".format(csharp_native_lib_name)],
+        out = namespace,
         nullable = nullable_context,
         target_frameworks = target_frameworks,
         targeting_packs = targeting_packs,

distribution/deployment.bzl

@@ -58,6 +58,10 @@ deployment = {
         "release": "https://upload.pypi.org/legacy/",
         "snapshot": "https://python.cloudsmith.io/typedb/public-snapshot/",
     },
+    "nuget" : {
+        "release": "https://api.nuget.org/v3/index.json",
+        "snapshot": "https://nuget.cloudsmith.io/typedb/public-snapshot/v3/index.json",
+    },
 }
 
 deployment_private = {

distribution/deps.bzl

@@ -9,5 +9,5 @@ def vaticle_bazel_distribution():
     git_repository(
         name = "vaticle_bazel_distribution",
         remote = "https://github.com/vaticle/bazel-distribution",
-        commit = "c473d17530dff5a4398d2de9c9fe966df9aca4ce" # sync-marker: do not remove this comment, this is used for sync-dependencies by @vaticle_bazel_distribution
+        commit = "5e8c09ddbb20571c8a48651210494ac68fcf8ae7" # sync-marker: do not remove this comment, this is used for sync-dependencies by @vaticle_bazel_distribution
     )