Skip to content
This repository was archived by the owner on Oct 9, 2023. It is now read-only.

Upgrade to Grakn 2.0 #133

Merged
merged 26 commits into from
Dec 15, 2020
Merged

Upgrade to Grakn 2.0 #133

merged 26 commits into from
Dec 15, 2020

Conversation

@alexjpwalker
Copy link
Member

@alexjpwalker alexjpwalker commented Nov 27, 2020 •
edited
Loading

What is the goal of this PR?

We upgraded the client to be compatible with Grakn 2.0. This is a major overhaul that heavily impacts the entire codebase.

What are the changes implemented in this PR?

  • Update all Concept, Query, Logic, Session and Database methods to be compatible with Grakn version 2.0
  • Close alignment of structure and implementation with client-java
  • Add simple E2E tests that verify the correctness of all methods
  • Grakn's protocol is now a separate pip package and CI/CD is handled exclusively by Grabl

@alexjpwalker alexjpwalker self-assigned this Nov 27, 2020
@alexjpwalker alexjpwalker linked an issue Nov 27, 2020 that may be closed by this pull request
Upgrade to Grakn 2.0 #132
Closed
Alex Walker added 24 commits December 7, 2020 13:32
Initial 2.0 commit with db/session creation + basic test
b6572c5
fix build
fa34d41
Implement opening and closing transactions
f239037
Update protocol
dcf75b5
Implement streaming RPCs
aa39082
Implement session pulse
bf97412
Implement commit, rollback; verify streaming works
5dcd015
Exclude test_grakn - we should migrate it to BDD
efd6398
Rename test_answer to test_query
5371e6a
Stronger typing
d001ff1
Implement query package
391ee44
ConceptManager and ConceptMap
c946b84
Implement all Types
eea93ba
Begin implementing concept.thing
17c08b4
Rename proto_builder files for clarity
e89292c
Implement all Things
8fd9615
LogicManager and Rule
c6f1b68
Fix Graql Match and Insert throwing errors
b19569b
Test all Concept methods and most Query methods
4f7ea26
Fix Concept API
a72bbec
Don't run e2e tests in CI - they aren't CI ready
075e071
Update grakn core artifact
5f03fd1
Fix Grakn failing to download
34306b4
License headers
38ec96a
@alexjpwalker alexjpwalker marked this pull request as ready for review December 15, 2020 16:57
@alexjpwalker alexjpwalker requested a review from lolski December 15, 2020 16:59
@lolski lolski merged commit 5b39e27 into typedb:master Dec 15, 2020
@alexjpwalker alexjpwalker deleted the 2.0 branch December 15, 2020 17:02
This was linked to issues Dec 16, 2020
Incompatibility with Python >=3.8 caused by grpcio 1.24 #131
Closed
Provide __str__ implementations for Client Objects #74
Closed
@alexjpwalker alexjpwalker mentioned this pull request Dec 17, 2020
Closed
@lolski lolski added this to the 2.0.0-alpha milestone Jan 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@flyingsilverfin flyingsilverfin Awaiting requested review from flyingsilverfin flyingsilverfin is a code owner

@vmax vmax Awaiting requested review from vmax

1 more reviewer

@lolski lolski lolski approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@alexjpwalker alexjpwalker

Labels

priority: high type: feature

Projects

None yet

Milestone

2.0.0-alpha

Development

Successfully merging this pull request may close these issues.

Upgrade to Grakn 2.0 Incompatibility with Python >=3.8 caused by grpcio 1.24 Provide __str__ implementations for Client Objects

3 participants

@alexjpwalker @lolski @mkschulze