Implement serde traits for JSON #782
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| seq.end() | ||
| } | ||
| Self::String(string) => serializer.serialize_str(string), | ||
| &Self::Number(number) => serializer.serialize_f64(number), |
Member
There was a problem hiding this comment.
huh do all our JSONS only return floats?
Member
Author
There was a problem hiding this comment.
We're following the JSON spec here.
flyingsilverfin
approved these changes
Sep 8, 2025
Member
flyingsilverfin
left a comment
flyingsilverfin
left a comment
There was a problem hiding this comment.
Looks good but i just noticed we only have f64 for numbers - was that something we intended?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage and product changes
We implement serde's
SerializeforConceptDocumentand our customJSONtype. This allows crates likeaxumthat rely onserdeto seamlessly returnJson<ConceptDocument>from request handlers.We also implement
DeserializeforJSONfor convenience.Implementation
Closes #766