Skip to content

Commit 43e0ea3

Browse files
Prefixed artifact IDs of Maven packages with 'grakn-' (#3)
## What is the goal of this PR? When deploying Maven JARs to Sonatype, the JARs are renamed to be `artifact-id-version.jar`, without the `group-id`. This is done in Sonatype because the JARs are organised into folders where the folder names represent the Group IDs. However, in certain build systems, e.g. Gradle, the JARs are collected under one directory, which means the JAR names are not unique enough to disambiguate itself from each other. We have now renamed the artifact ID of our Maven packages to be prefixed with `grakn-` to solve this problem. ## What are the changes implemented in this PR? Prefixed artifact IDs of Maven packages with 'grakn-' (fixes typedb/typedb#5127, fixes typedb/bazel-distribution#112).
1 parent 393b8ea commit 43e0ea3

File tree

3 files changed

+3
-4
lines changed

3 files changed

+3
-4
lines changed

.circleci/config.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,8 +65,7 @@ jobs:
6565
bazel run @graknlabs_build_tools//ci:sync-dependencies -- \
6666
--source protocol@$CIRCLE_SHA1 \
6767
--targets \
68-
grakn:master client-java:master client-python:master
69-
# TODO: Add client-nodejs:master
68+
grakn:master client-java:master client-python:master client-nodejs:master
7069
7170
release-approval:
7271
machine: true

keyspace/BUILD

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ java_library(
4343
"//dependencies/maven/artifacts/io/grpc:grpc-protobuf",
4444
"//dependencies/maven/artifacts/io/grpc:grpc-stub",
4545
],
46-
tags = ["maven_coordinates=io.grakn.protocol:keyspace:{pom_version}", "checkstyle_ignore"],
46+
tags = ["maven_coordinates=io.grakn.protocol:grakn-keyspace:{pom_version}", "checkstyle_ignore"],
4747
)
4848

4949
assemble_maven(

session/BUILD

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ java_library(
5757
"//dependencies/maven/artifacts/io/grpc:grpc-protobuf",
5858
"//dependencies/maven/artifacts/io/grpc:grpc-stub",
5959
],
60-
tags = ["maven_coordinates=io.grakn.protocol:session:{pom_version}", "checkstyle_ignore"],
60+
tags = ["maven_coordinates=io.grakn.protocol:grakn-session:{pom_version}", "checkstyle_ignore"],
6161
)
6262

6363
assemble_maven(

0 commit comments

Comments
 (0)